Skip to content

MX-189: Fix the API 08. REQUEST A NEW LOAN ACCOUNT (SUBMIT AN APPLICA… - #128

Merged
IOhacker merged 1 commit into
openMF:developfrom
IOhacker:develop
Apr 12, 2026
Merged

MX-189: Fix the API 08. REQUEST A NEW LOAN ACCOUNT (SUBMIT AN APPLICA…#128
IOhacker merged 1 commit into
openMF:developfrom
IOhacker:develop

Conversation

@IOhacker

@IOhacker IOhacker commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

…TION)

Summary by CodeRabbit

Release Notes

  • New Features
    • Self-service users now have permission to create loan accounts, enabling direct loan account management through the self-service platform.

@IOhacker
IOhacker merged commit 3a1a630 into openMF:develop Apr 12, 2026
1 of 2 checks passed
@coderabbitai

coderabbitai Bot commented Apr 12, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 92644bd9-01b2-4c7c-be36-bf96966bc42e

📥 Commits

Reviewing files that changed from the base of the PR and between 5fd1ffc and 6983254.

📒 Files selected for processing (2)
  • src/main/resources/db/changelog/tenant/module/selfservice/module-changelog-master.xml
  • src/main/resources/db/changelog/tenant/module/selfservice/parts/013-grant-selfservice-loan-account-create-account-permissions.xml

📝 Walkthrough

Walkthrough

This pull request adds a new Liquibase changelog migration to grant the CREATE_LOAN permission to the Self Service User role. It includes one master changelog include directive and a new changeSet file containing a conditional SQL insert statement.

Changes

Cohort / File(s) Summary
Permission Grant Migration
src/main/resources/db/changelog/tenant/module/selfservice/module-changelog-master.xml, src/main/resources/db/changelog/tenant/module/selfservice/parts/013-grant-selfservice-loan-account-create-account-permissions.xml
Added new Liquibase changelog include in master file and created corresponding changeSet that conditionally inserts CREATE_LOAN permission mapping to m_role_permission table for the Self Service User role with precondition checks and duplicate prevention via NOT EXISTS.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

⏱️ <10 Min Review

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant