Skip to content

WEB-841 Update Cancel button styling in Floating Rate Periods dialog - #3363

Merged
IOhacker merged 1 commit into
openMF:devfrom
JaySoni1:WEB-841-update-cancel-button-styling-in-floating-rate-periods-dialog
Mar 12, 2026
Merged

WEB-841 Update Cancel button styling in Floating Rate Periods dialog#3363
IOhacker merged 1 commit into
openMF:devfrom
JaySoni1:WEB-841-update-cancel-button-styling-in-floating-rate-periods-dialog

Conversation

@JaySoni1

@JaySoni1 JaySoni1 commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Changes Made :-

-Changed Cancel button from mat-button to mat-raised-button in Floating Rate Periods dialog to maintain consistent styling across dialogs .

WEB- 841

Before :-

image

After :-

image

Summary by CodeRabbit

  • Style
    • Updated Cancel button styling in the Floating Rate Period dialog to use a raised button style for enhanced visual emphasis.
    • Modified Cancel button styling in the Create Range dialog to use a standard text button style for a streamlined appearance.

@coderabbitai

coderabbitai Bot commented Mar 12, 2026

Copy link
Copy Markdown

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Two Cancel buttons in Material Design dialog components had their styling adjusted. The floating-rate-period-dialog button changed from flat to raised style, while the create-range button changed from raised to standard text style. No functional or behavioral modifications.

Changes

Cohort / File(s) Summary
Button Styling Updates
src/app/products/floating-rates/floating-rate-period-dialog/floating-rate-period-dialog.component.html, src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html
Modified Cancel button Material Design directives—one changed to raised style, the other to standard text button. Pure visual/elevation changes with no impact on form logic or routing behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • IOhacker
  • gkbishnoi07
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions updating Cancel button styling in the Floating Rate Periods dialog, which aligns with the primary change. However, the PR also includes a separate change to a Cancel button in the create-range component that is not mentioned in the title. Clarify whether the PR scope is only the Floating Rate Periods dialog or if it includes both dialog changes. Consider revising the title to reflect all meaningful changes or splitting into separate PRs.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html (1)

34-36: Pre-existing: Hardcoded string should use i18n.

Not introduced by this PR, but since the file is being modified: line 35 has a hardcoded English string that should use the translate pipe for consistency with the rest of the codebase.

-            <mat-error> {{ 'labels.inputs.Days From' | translate }} must be a positive number. </mat-error>
+            <mat-error> {{ 'labels.inputs.Days From' | translate }} {{ 'labels.validations.must be a positive number' | translate }} </mat-error>

As per coding guidelines: "Use proper i18n variables from @ngx-translate/core for all user-facing strings instead of hardcoded text."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html`
around lines 34 - 36, Replace the hardcoded English message inside the
<mat-error> for delinquencyRangeForm.controls.minimumAgeDays.hasError('pattern')
with a translated string using the translate pipe (e.g. use "{{
'validation.positiveNumber' | translate }}" or an appropriate i18n key), and add
that key and message to your translation files; update the template's
<mat-error> text to use the translate pipe and ensure the i18n key is added to
the localization resources so the message for the minimumAgeDays pattern error
is internationalized.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html`:
- Around line 34-36: Replace the hardcoded English message inside the
<mat-error> for delinquencyRangeForm.controls.minimumAgeDays.hasError('pattern')
with a translated string using the translate pipe (e.g. use "{{
'validation.positiveNumber' | translate }}" or an appropriate i18n key), and add
that key and message to your translation files; update the template's
<mat-error> text to use the translate pipe and ensure the i18n key is added to
the localization resources so the message for the minimumAgeDays pattern error
is internationalized.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 985f42fc-77cb-456f-9821-387b5058b0ff

📥 Commits

Reviewing files that changed from the base of the PR and between 4ad6c04 and ff1a543.

📒 Files selected for processing (2)
  • src/app/products/floating-rates/floating-rate-period-dialog/floating-rate-period-dialog.component.html
  • src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html

@IOhacker IOhacker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker
IOhacker merged commit 90c20fa into openMF:dev Mar 12, 2026
6 checks passed
@JaySoni1

Copy link
Copy Markdown
Contributor Author

@IOhacker Thank You for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants