Skip to content

WEB-869 Standardize cancel button styling to mat raised button across different dialogs - #3399

Merged
IOhacker merged 1 commit into
openMF:devfrom
JaySoni1:WEB-869-standardize-cancel-button-styling-to-mat-raised-button-across-different-dialogs
Mar 17, 2026
Merged

WEB-869 Standardize cancel button styling to mat raised button across different dialogs#3399
IOhacker merged 1 commit into
openMF:devfrom
JaySoni1:WEB-869-standardize-cancel-button-styling-to-mat-raised-button-across-different-dialogs

Conversation

@JaySoni1

@JaySoni1 JaySoni1 commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Changes Made :-

-Updated Cancel button styling from mat-button to mat-raised-button in three dialog components to maintain consistent styling across the application:

Report Parameter Dialog (manage-reports)
Add Event Dialog (manage-hooks)
Column Dialog (manage-data-tables) .

WEB-869

Before :-

image image image

After :-

image image image

Summary by CodeRabbit

  • Style
    • Updated Cancel button styling in dialog components across column management, event management, and report parameter features to use raised button appearance for improved visual consistency.

@coderabbitai

coderabbitai Bot commented Mar 17, 2026

Copy link
Copy Markdown

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5c674d01-2be3-4a27-ad67-ca0144a8406a

📥 Commits

Reviewing files that changed from the base of the PR and between 767c928 and d9d50e7.

📒 Files selected for processing (3)
  • src/app/system/manage-data-tables/column-dialog/column-dialog.component.html
  • src/app/system/manage-hooks/add-event-dialog/add-event-dialog.component.html
  • src/app/system/manage-reports/report-parameter-dialog/report-parameter-dialog.component.html

Walkthrough

This PR updates the visual styling of Cancel buttons across three dialog components, changing them from flat buttons (mat-button) to raised buttons (mat-raised-button). The modifications are purely presentational with no impact on button behavior or dialog control flow.

Changes

Cohort / File(s) Summary
Button Styling Updates
src/app/system/manage-data-tables/column-dialog/column-dialog.component.html, src/app/system/manage-hooks/add-event-dialog/add-event-dialog.component.html, src/app/system/manage-reports/report-parameter-dialog/report-parameter-dialog.component.html
Cancel buttons updated from mat-button to mat-raised-button for consistent visual appearance across dialog components. No functional changes to button behavior or dialog logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • IOhacker
  • steinwinde
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: standardizing Cancel button styling to mat-raised-button across three dialog components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@IOhacker IOhacker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@IOhacker
IOhacker merged commit 8423176 into openMF:dev Mar 17, 2026
6 checks passed
@JaySoni1

Copy link
Copy Markdown
Contributor Author

@IOhacker Thank you for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants