Skip to content

[exec-server] Kill dropped filesystem helpers#25116

Merged
erichoracek merged 1 commit into
mainfrom
dev/eh/fs-helper-bounded-timeout
May 29, 2026
Merged

[exec-server] Kill dropped filesystem helpers#25116
erichoracek merged 1 commit into
mainfrom
dev/eh/fs-helper-bounded-timeout

Conversation

@erichoracek
Copy link
Copy Markdown
Contributor

@erichoracek erichoracek commented May 29, 2026

Summary

  • terminate sandbox filesystem helpers when the Tokio child handle is dropped

Why

A sandbox filesystem helper can stall during process startup before reading stdin. If the owning async operation is cancelled or torn down, the spawned helper should not remain running as an orphaned process.

Setting kill_on_drop(true) gives the filesystem helper the cleanup behavior that Tokio child processes otherwise do not enable by default.

This intentionally does not add a timeout. It does not detect or recover an active hung file edit while the owning future remains alive. A more precise startup-health mechanism can be handled separately.

Validation

  • just test -p codex-exec-server (186 tests passed; benchmark smoke passed)
  • just fmt
  • just fix -p codex-exec-server
  • git diff --check

@erichoracek erichoracek force-pushed the dev/eh/fs-helper-bounded-timeout branch from 76b677b to 40be805 Compare May 29, 2026 17:33
@erichoracek erichoracek changed the title [exec-server] Timeout bounded filesystem helpers [exec-server] Kill dropped filesystem helpers May 29, 2026
@erichoracek erichoracek marked this pull request as ready for review May 29, 2026 18:39
@erichoracek erichoracek merged commit 451b386 into main May 29, 2026
31 checks passed
@erichoracek erichoracek deleted the dev/eh/fs-helper-bounded-timeout branch May 29, 2026 18:40
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants