[exec-server] Require filesystem helper readiness#25120
Closed
erichoracek wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Summary
Why
A sandbox filesystem helper can stall during process startup before reading stdin. Waiting for a flushed readiness marker gives the parent a precise startup-health signal: if the helper never reaches its Rust entrypoint, the parent returns an error and the dropped child is cleaned up by the
kill_on_drop(true)behavior from #25116.This intentionally does not apply an arbitrary timeout to filesystem work after startup.
Validation
just test -p codex-exec-server(188 tests passed; benchmark smoke passed)just fmtjust fix -p codex-exec-servergit diff --check