Skip to content

[exec-server] Require filesystem helper readiness#25120

Closed
erichoracek wants to merge 2 commits into
mainfrom
dev/eh/fs-helper-ready-handshake
Closed

[exec-server] Require filesystem helper readiness#25120
erichoracek wants to merge 2 commits into
mainfrom
dev/eh/fs-helper-ready-handshake

Conversation

@erichoracek
Copy link
Copy Markdown
Contributor

Stack

Summary

  • emit and flush a readiness marker from the sandbox filesystem helper before it waits for request input
  • require the parent process to receive that marker within 10 seconds before sending the filesystem request
  • preserve the existing unbounded wait for the filesystem operation itself
  • add focused regression coverage for marker consumption and startup timeout

Why

A sandbox filesystem helper can stall during process startup before reading stdin. Waiting for a flushed readiness marker gives the parent a precise startup-health signal: if the helper never reaches its Rust entrypoint, the parent returns an error and the dropped child is cleaned up by the kill_on_drop(true) behavior from #25116.

This intentionally does not apply an arbitrary timeout to filesystem work after startup.

Validation

  • just test -p codex-exec-server (188 tests passed; benchmark smoke passed)
  • just fmt
  • just fix -p codex-exec-server
  • git diff --check

Base automatically changed from dev/eh/fs-helper-bounded-timeout to main May 29, 2026 18:40
@erichoracek erichoracek deleted the dev/eh/fs-helper-ready-handshake branch May 29, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant