Skip to content

Load platform MITM CA roots#26285

Closed
winston-openai wants to merge 8 commits into
mainfrom
dev/winston/mitm-platform-ca-roots
Closed

Load platform MITM CA roots#26285
winston-openai wants to merge 8 commits into
mainfrom
dev/winston/mitm-platform-ca-roots

Conversation

@winston-openai

@winston-openai winston-openai commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Why

The managed MITM baseline must come from platform trust, not inherited startup CA overrides that may be command-specific or unreadable inside a sandbox.

What

  • load platform-native roots without consulting inherited SSL_CERT_FILE or SSL_CERT_DIR
  • keep startup CA overrides out of the baseline managed bundle until child policy can be checked
  • cover the startup-override regression in codex-network-proxy

Stack

Validation

  • just test -p codex-network-proxy
  • just bazel-lock-check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4d37e04e81

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread codex-rs/network-proxy/src/native_certs.rs Outdated
@winston-openai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5891f041b2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread codex-rs/network-proxy/src/certs.rs
@winston-openai winston-openai force-pushed the dev/winston/mitm-platform-ca-roots branch from 39c17fd to 750e73e Compare June 4, 2026 10:45

Copy link
Copy Markdown
Contributor Author

Closing as superseded by the focused #29013 and #29014 stack. The replacement isolates the persisted MITM private key and preserves file-backed custom CAs present at Codex startup, with zero codex-core changes. Per-command bundle materialization, generic sandbox carvebacks, and additional shell-snapshot plumbing are intentionally deferred because they are not required for this scoped completion work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant