Skip to content

Expose child MITM CA env preparation#26286

Closed
winston-openai wants to merge 11 commits into
dev/winston/mitm-ca-bundle-helpersfrom
dev/winston/mitm-child-ca-materialization
Closed

Expose child MITM CA env preparation#26286
winston-openai wants to merge 11 commits into
dev/winston/mitm-ca-bundle-helpersfrom
dev/winston/mitm-child-ca-materialization

Conversation

@winston-openai

@winston-openai winston-openai commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Stack

  1. Parent PR: Track startup MITM CA env #26314
  2. Parent PR: Materialize child MITM CA bundles #26315
  3. This PR exposes child MITM CA env preparation from NetworkProxy.
  4. Child PR: Prepare managed child MITM CA env #25888

Summary

  1. Add NetworkProxy::prepare_child_env() as the network-proxy entry point for child-specific MITM CA preparation.
  2. Keep sandbox/runtime launch wiring in the follow-up PR.

Validation

  1. Ran just test -p codex-network-proxy.
  2. Ran just fix -p codex-network-proxy.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de3ce08628

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread codex-rs/network-proxy/src/proxy.rs
Comment thread codex-rs/network-proxy/src/proxy.rs
Comment thread codex-rs/network-proxy/src/child_ca.rs Outdated
@winston-openai winston-openai force-pushed the dev/winston/mitm-child-ca-materialization branch from a4bbd33 to c9014ad Compare June 4, 2026 02:27
@winston-openai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9014ad029

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread codex-rs/network-proxy/Cargo.toml
Comment thread codex-rs/network-proxy/src/proxy.rs
Comment thread codex-rs/network-proxy/src/child_ca.rs
Comment thread codex-rs/network-proxy/src/certs.rs Outdated
Comment thread codex-rs/network-proxy/src/child_ca.rs
@winston-openai

Copy link
Copy Markdown
Contributor Author

@codex review

@winston-openai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb6ce7fef9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread codex-rs/network-proxy/src/proxy.rs
Comment thread codex-rs/network-proxy/Cargo.toml
Comment thread codex-rs/network-proxy/src/child_ca.rs
Comment thread codex-rs/network-proxy/src/certs.rs
@winston-openai winston-openai changed the title Materialize child MITM CA bundles Expose child MITM CA env preparation Jun 4, 2026
@winston-openai winston-openai changed the base branch from dev/winston/mitm-platform-ca-roots to dev/winston/mitm-ca-bundle-helpers June 4, 2026 05:21
@winston-openai

Copy link
Copy Markdown
Contributor Author

Folded this 38-line entrypoint into #26315 so the bundle-helper stage is coherent and clippy-clean on its own. This PR is now empty against its parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant