Expose explicit dynamic tool namespaces in thread start#27371
Merged
Conversation
sayan-oai
force-pushed
the
codex/dynamic-tool-explicit-namespaces-core
branch
from
June 11, 2026 04:16
1765bf7 to
acca13f
Compare
sayan-oai
force-pushed
the
codex/dynamic-tool-explicit-namespaces-api
branch
2 times, most recently
from
June 11, 2026 04:45
0501a07 to
e0bb3c7
Compare
sayan-oai
commented
Jun 11, 2026
Comment on lines
-41
to
-43
| #[derive(Serialize, Debug, Clone, PartialEq, JsonSchema, TS)] | ||
| #[serde(rename_all = "camelCase")] | ||
| #[ts(export_to = "v2/")] |
Contributor
Author
There was a problem hiding this comment.
lmk if this is an antipattern and we'd rather define the types in app-server and protocol, i know we duplicate other types.
sayan-oai
commented
Jun 11, 2026
|
|
||
| /// Exercises the full dynamic tool call path (server request, client response, model output). | ||
| #[tokio::test] | ||
| async fn dynamic_tool_call_round_trip_sends_text_content_items_to_model() -> Result<()> { |
Contributor
Author
There was a problem hiding this comment.
main happy path integration test; updated with new types
sayan-oai
marked this pull request as ready for review
June 11, 2026 05:38
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f2b5e0a6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
|
@codex review this |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f2b5e0a6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
sayan-oai
force-pushed
the
codex/dynamic-tool-explicit-namespaces-core
branch
from
June 11, 2026 08:50
ab8c1e5 to
c856ed2
Compare
sayan-oai
force-pushed
the
codex/dynamic-tool-explicit-namespaces-api
branch
from
June 11, 2026 08:51
9f2b5e0 to
8ed9281
Compare
jif-oai
reviewed
Jun 11, 2026
sayan-oai
force-pushed
the
codex/dynamic-tool-explicit-namespaces-api
branch
from
June 12, 2026 08:23
8ed9281 to
b2bee78
Compare
jif-oai
approved these changes
Jun 12, 2026
jif-oai
left a comment
jif-oai
left a comment
Contributor
There was a problem hiding this comment.
Can we add a thread/start integration test for duplicate namespace containers? Just to lock the behaviour explicitly
sayan-oai
force-pushed
the
codex/dynamic-tool-explicit-namespaces-api
branch
from
June 12, 2026 19:05
b2bee78 to
1b4b9a6
Compare
jif-oai
approved these changes
Jun 15, 2026
sayan-oai
added a commit
that referenced
this pull request
Jun 15, 2026
Follow-up to #27356. ## Stack note This PR changes Codex's internal dynamic-tool shape while leaving `thread/start` unchanged. App-server therefore converts the existing per-tool input into explicit functions and namespaces before passing it to core. [#27371](#27371) updates `thread/start` to use the same explicit shape and removes this temporary conversion. ## Why Dynamic tools repeat namespace metadata on every function. Core should keep one explicit namespace with its member tools so descriptions and membership stay consistent across sessions and runtime planning. ## What changed - Represent dynamic tools as top-level functions or explicit namespaces in protocol and session state. - Read old flat rollout metadata and write the canonical hierarchy. - Flatten namespace members only when registering callable tools. - Keep `thread/start.dynamicTools` flat for now and normalize it at the app-server boundary. New builds can read old rollout metadata. Older builds cannot read newly written hierarchical metadata. ## Test plan - `just test -p codex-app-server thread_start_normalizes_legacy_dynamic_tools_into_model_request` - `just test -p codex-protocol session_meta_normalizes_legacy_dynamic_tools` - `just test -p codex-core resume_restores_dynamic_tools_from_rollout_with_sqlite_enabled` - `just test -p codex-core tool_search_returns_deferred_dynamic_tool_and_routes_follow_up_call` - `just test -p codex-core code_mode_can_call_hidden_dynamic_tools` - `just test -p codex-tools`
Base automatically changed from
codex/dynamic-tool-explicit-namespaces-core
to
main
June 15, 2026 15:06
sayan-oai
force-pushed
the
codex/dynamic-tool-explicit-namespaces-api
branch
from
June 15, 2026 15:20
1b4b9a6 to
fe2b08e
Compare
sayan-oai
enabled auto-merge (squash)
June 15, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #27365.
Stack note
#27365 kept
thread/startunchanged and converted its input inthread_processor. This PR updatesthread/startto accept explicit functions and namespaces directly.Legacy per-tool arrays are still accepted and converted while reading the request. As a result,
thread_processorcan validate and pass the tools through directly, which is why some code added in #27365 is removed here.Why
thread/start.dynamicToolsstill repeats namespace data on each function even though core now stores explicit namespace groups. The request API should use the same shape so each namespace has one description and one member list.What changed
dynamicTools.exposeToContext.Test plan
just test -p codex-app-server-protocoljust test -p codex-app-server dynamic_tool_call_round_trip_sends_text_content_items_to_modeljust test -p codex-app-server thread_start_normalizes_legacy_dynamic_tools_into_model_requestjust test -p codex-app-server thread_start_rejects_mixed_dynamic_tool_formatsjust test -p codex-app-server thread_start_rejects_hidden_dynamic_tools_without_namespace