Skip to content

[codex] [3/4] Activate endpoint plugin recommendations#27704

Merged
adaley-openai merged 8 commits into
mainfrom
dev/adaley/recommended-plugin-hint-experiment
Jun 16, 2026
Merged

[codex] [3/4] Activate endpoint plugin recommendations#27704
adaley-openai merged 8 commits into
mainfrom
dev/adaley/recommended-plugin-hint-experiment

Conversation

@adaley-openai

@adaley-openai adaley-openai commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary\n- Await endpoint recommendation selection while constructing each authenticated turn, removing the first-turn cache race.\n- Snapshot and filter endpoint candidates once per turn, then use that same set for the bounded contextual user fragment, tool exposure, and exact install validation.\n- Keep recommendation selection ephemeral: do not persist recommendation state in or gate resumed threads on prior context.\n- Hide the legacy list tool in endpoint mode and preserve legacy discovery unchanged when the endpoint is disabled or unavailable.\n- Keep remote plugin and connector app identities out of model-visible context and attach them only to Codex-owned elicitation metadata.\n\nStack\n- 3/4, based on #28400.\n- Endpoint client and cache: #28399.\n- Generalized suggestion presentation: #28400.\n- Install-schema follow-up: #28403.\n\nValidation\n- \n- \n- \n- \n- Full : 2,649 passed and 88 environment-dependent tests failed because this sandbox cannot write , nest Seatbelt, or locate auxiliary test binaries.

@adaley-openai
adaley-openai requested a review from a team as a code owner June 11, 2026 23:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e59decf6bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/context/recommended_plugins_instructions.rs
Comment thread codex-rs/core/src/context/recommended_plugins_instructions.rs Outdated
Comment thread codex-rs/core/src/session/turn.rs Outdated
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch 5 times, most recently from b54d464 to 3fc7249 Compare June 15, 2026 16:32
Comment thread codex-rs/core-plugins/src/manager.rs
Comment thread codex-rs/app-server/src/request_processors/account_processor.rs Outdated
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from f624e26 to 831815e Compare June 15, 2026 22:25
@adaley-openai adaley-openai changed the title [codex] Add endpoint-driven plugin recommendations [codex] [3/3] Activate endpoint plugin recommendations Jun 15, 2026
@adaley-openai
adaley-openai changed the base branch from main to dev/adaley/generalize-plugin-suggestion-tools June 15, 2026 22:25
@adaley-openai
adaley-openai force-pushed the dev/adaley/generalize-plugin-suggestion-tools branch from 8f68622 to d1ab190 Compare June 15, 2026 23:25
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 831815e to 1aaa60a Compare June 15, 2026 23:25
@adaley-openai
adaley-openai force-pushed the dev/adaley/generalize-plugin-suggestion-tools branch 2 times, most recently from 58cdc7a to 155cdfe Compare June 15, 2026 23:35
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 1aaa60a to 58db110 Compare June 15, 2026 23:36
@adaley-openai
adaley-openai force-pushed the dev/adaley/generalize-plugin-suggestion-tools branch from 155cdfe to 132f097 Compare June 16, 2026 00:10
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 58db110 to 3b66932 Compare June 16, 2026 00:11
@adaley-openai
adaley-openai force-pushed the dev/adaley/generalize-plugin-suggestion-tools branch from 132f097 to 0c7a6a4 Compare June 16, 2026 00:28
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 3b66932 to 4fa7092 Compare June 16, 2026 00:29
Comment thread codex-rs/core/src/session/mod.rs Outdated
@adaley-openai adaley-openai changed the title [codex] [3/3] Activate endpoint plugin recommendations [codex] [3/4] Activate endpoint plugin recommendations Jun 16, 2026
Comment thread codex-rs/core/src/context/recommended_plugins_instructions.rs
Comment thread codex-rs/core/tests/suite/request_plugin_install.rs Outdated
Comment thread codex-rs/core/src/session/turn_context.rs Outdated
Comment thread codex-rs/core/src/session/turn_context.rs Outdated
Comment thread codex-rs/core/src/session/mod.rs Outdated

@sayan-oai sayan-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one more comment, thank you for bearing with me!

Comment thread codex-rs/core-plugins/src/manager.rs
adaley-openai added a commit that referenced this pull request Jun 16, 2026
Summary
- Add authenticated parsing for `/ps/plugins/suggested?scope=GLOBAL`,
including remote plugin and connector app identities.
- Validate, deduplicate, sort, and cap endpoint candidates before
caching them by backend and account identity.
- Deduplicate concurrent cache misses and warm recommendations from the
existing remote-installed-plugin refresh path used at startup and after
account changes.
- Keep endpoint results model-invisible in this PR; failures and
responses without `enabled: true` resolve to legacy mode.

Stack
- 1/3. Follow-up: #28400 generalizes plugin suggestion presentation
without activating endpoint recommendations.
- Final activation: #27704.

Validation
- `just test -p codex-core-plugins recommended_plugins`
- `just fix -p codex-core-plugins`
- `just fmt`
- `git diff --check`
@adaley-openai
adaley-openai force-pushed the dev/adaley/generalize-plugin-suggestion-tools branch from 0c7a6a4 to 8c9169f Compare June 16, 2026 22:23
adaley-openai added a commit that referenced this pull request Jun 16, 2026
Summary
- Add list-backed and developer-context presentations for plugin
suggestion candidates.
- Let tool planning, install validation, and request-tool copy follow
the selected presentation.
- Keep every production caller on the existing list-backed presentation,
preserving the current list tool, request schema, connector behavior,
and model-visible copy.
- Leave developer-context presentation latent until the final PR in the
stack.

Stack
- 2/3, based on #28399.
- Follow-up: #27704 activates endpoint recommendations.

Validation
- `just test -p codex-core request_plugin_install`
- `just test -p codex-core spec_plan`
- `just fix -p codex-core`
- `just fmt`
- `git diff --check`
Base automatically changed from dev/adaley/generalize-plugin-suggestion-tools to main June 16, 2026 22:44
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from e5f2f30 to bc40f0f Compare June 16, 2026 22:46
@adaley-openai
adaley-openai enabled auto-merge (squash) June 16, 2026 22:53
@adaley-openai
adaley-openai merged commit a34da3b into main Jun 16, 2026
46 of 47 checks passed
@adaley-openai
adaley-openai deleted the dev/adaley/recommended-plugin-hint-experiment branch June 16, 2026 23:04
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants