[codex] [3/4] Activate endpoint plugin recommendations#27704
Merged
adaley-openai merged 8 commits intoJun 16, 2026
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e59decf6bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
adaley-openai
force-pushed
the
dev/adaley/recommended-plugin-hint-experiment
branch
5 times, most recently
from
June 15, 2026 16:32
b54d464 to
3fc7249
Compare
xl-openai
reviewed
Jun 15, 2026
xl-openai
reviewed
Jun 15, 2026
This was referenced Jun 15, 2026
adaley-openai
force-pushed
the
dev/adaley/recommended-plugin-hint-experiment
branch
from
June 15, 2026 22:25
f624e26 to
831815e
Compare
adaley-openai
changed the base branch from
main
to
dev/adaley/generalize-plugin-suggestion-tools
June 15, 2026 22:25
adaley-openai
force-pushed
the
dev/adaley/generalize-plugin-suggestion-tools
branch
from
June 15, 2026 23:25
8f68622 to
d1ab190
Compare
adaley-openai
force-pushed
the
dev/adaley/recommended-plugin-hint-experiment
branch
from
June 15, 2026 23:25
831815e to
1aaa60a
Compare
adaley-openai
force-pushed
the
dev/adaley/generalize-plugin-suggestion-tools
branch
2 times, most recently
from
June 15, 2026 23:35
58cdc7a to
155cdfe
Compare
adaley-openai
force-pushed
the
dev/adaley/recommended-plugin-hint-experiment
branch
from
June 15, 2026 23:36
1aaa60a to
58db110
Compare
adaley-openai
force-pushed
the
dev/adaley/generalize-plugin-suggestion-tools
branch
from
June 16, 2026 00:10
155cdfe to
132f097
Compare
adaley-openai
force-pushed
the
dev/adaley/recommended-plugin-hint-experiment
branch
from
June 16, 2026 00:11
58db110 to
3b66932
Compare
adaley-openai
force-pushed
the
dev/adaley/generalize-plugin-suggestion-tools
branch
from
June 16, 2026 00:28
132f097 to
0c7a6a4
Compare
adaley-openai
force-pushed
the
dev/adaley/recommended-plugin-hint-experiment
branch
from
June 16, 2026 00:29
3b66932 to
4fa7092
Compare
sayan-oai
reviewed
Jun 16, 2026
sayan-oai
reviewed
Jun 16, 2026
sayan-oai
reviewed
Jun 16, 2026
sayan-oai
reviewed
Jun 16, 2026
sayan-oai
reviewed
Jun 16, 2026
sayan-oai
reviewed
Jun 16, 2026
sayan-oai
approved these changes
Jun 16, 2026
sayan-oai
left a comment
Contributor
There was a problem hiding this comment.
left one more comment, thank you for bearing with me!
xl-openai
reviewed
Jun 16, 2026
adaley-openai
added a commit
that referenced
this pull request
Jun 16, 2026
Summary - Add authenticated parsing for `/ps/plugins/suggested?scope=GLOBAL`, including remote plugin and connector app identities. - Validate, deduplicate, sort, and cap endpoint candidates before caching them by backend and account identity. - Deduplicate concurrent cache misses and warm recommendations from the existing remote-installed-plugin refresh path used at startup and after account changes. - Keep endpoint results model-invisible in this PR; failures and responses without `enabled: true` resolve to legacy mode. Stack - 1/3. Follow-up: #28400 generalizes plugin suggestion presentation without activating endpoint recommendations. - Final activation: #27704. Validation - `just test -p codex-core-plugins recommended_plugins` - `just fix -p codex-core-plugins` - `just fmt` - `git diff --check`
adaley-openai
force-pushed
the
dev/adaley/generalize-plugin-suggestion-tools
branch
from
June 16, 2026 22:23
0c7a6a4 to
8c9169f
Compare
adaley-openai
added a commit
that referenced
this pull request
Jun 16, 2026
Summary - Add list-backed and developer-context presentations for plugin suggestion candidates. - Let tool planning, install validation, and request-tool copy follow the selected presentation. - Keep every production caller on the existing list-backed presentation, preserving the current list tool, request schema, connector behavior, and model-visible copy. - Leave developer-context presentation latent until the final PR in the stack. Stack - 2/3, based on #28399. - Follow-up: #27704 activates endpoint recommendations. Validation - `just test -p codex-core request_plugin_install` - `just test -p codex-core spec_plan` - `just fix -p codex-core` - `just fmt` - `git diff --check`
Base automatically changed from
dev/adaley/generalize-plugin-suggestion-tools
to
main
June 16, 2026 22:44
adaley-openai
force-pushed
the
dev/adaley/recommended-plugin-hint-experiment
branch
from
June 16, 2026 22:46
e5f2f30 to
bc40f0f
Compare
adaley-openai
enabled auto-merge (squash)
June 16, 2026 22:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Await endpoint recommendation selection while constructing each authenticated turn, removing the first-turn cache race.\n- Snapshot and filter endpoint candidates once per turn, then use that same set for the bounded contextual user fragment, tool exposure, and exact install validation.\n- Keep recommendation selection ephemeral: do not persist recommendation state in or gate resumed threads on prior context.\n- Hide the legacy list tool in endpoint mode and preserve legacy discovery unchanged when the endpoint is disabled or unavailable.\n- Keep remote plugin and connector app identities out of model-visible context and attach them only to Codex-owned elicitation metadata.\n\nStack\n- 3/4, based on #28400.\n- Endpoint client and cache: #28399.\n- Generalized suggestion presentation: #28400.\n- Install-schema follow-up: #28403.\n\nValidation\n- \n- \n- \n- \n- Full : 2,649 passed and 88 environment-dependent tests failed because this sandbox cannot write , nest Seatbelt, or locate auxiliary test binaries.