Skip to content

[codex] [4/4] Simplify recommended plugin install schema#28403

Merged
adaley-openai merged 1 commit into
mainfrom
dev/adaley/simplify-recommended-plugin-install-schema
Jun 16, 2026
Merged

[codex] [4/4] Simplify recommended plugin install schema#28403
adaley-openai merged 1 commit into
mainfrom
dev/adaley/simplify-recommended-plugin-install-schema

Conversation

@adaley-openai

@adaley-openai adaley-openai commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Simplify recommendation-context request_plugin_install arguments to plugin_id and suggest_reason.
  • Derive plugin type and install action from the matched candidate while preserving Codex-owned elicitation metadata.
  • Keep the legacy list-backed schema unchanged and accept resumed calls that still use tool_id.

Stack

Validation

  • just test -p codex-tools -p codex-core request_plugin_install (25 passed)
  • just fix -p codex-tools -p codex-core
  • just fmt
  • git diff --check

@adaley-openai
adaley-openai requested a review from a team as a code owner June 15, 2026 22:43
@adaley-openai adaley-openai changed the title [codex] Simplify recommended plugin install schema [codex] [4/4] Simplify recommended plugin install schema Jun 15, 2026
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 831815e to 1aaa60a Compare June 15, 2026 23:25
@adaley-openai
adaley-openai force-pushed the dev/adaley/simplify-recommended-plugin-install-schema branch from a0d26e0 to 0e032c1 Compare June 15, 2026 23:25
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 1aaa60a to 58db110 Compare June 15, 2026 23:36
@adaley-openai
adaley-openai force-pushed the dev/adaley/simplify-recommended-plugin-install-schema branch from 0e032c1 to 2ad17aa Compare June 15, 2026 23:37
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 58db110 to 3b66932 Compare June 16, 2026 00:11
@adaley-openai
adaley-openai force-pushed the dev/adaley/simplify-recommended-plugin-install-schema branch from 2ad17aa to 6c9eed8 Compare June 16, 2026 00:12
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from 3b66932 to 4fa7092 Compare June 16, 2026 00:29
@adaley-openai
adaley-openai force-pushed the dev/adaley/simplify-recommended-plugin-install-schema branch from 6c9eed8 to 2bb609f Compare June 16, 2026 00:29
@adaley-openai
adaley-openai force-pushed the dev/adaley/simplify-recommended-plugin-install-schema branch from 2bb609f to 634b265 Compare June 16, 2026 17:21
@adaley-openai
adaley-openai force-pushed the dev/adaley/simplify-recommended-plugin-install-schema branch from 634b265 to f4b1983 Compare June 16, 2026 19:56
@adaley-openai
adaley-openai force-pushed the dev/adaley/simplify-recommended-plugin-install-schema branch 2 times, most recently from 82f0796 to 1b361d1 Compare June 16, 2026 21:24
@adaley-openai
adaley-openai force-pushed the dev/adaley/recommended-plugin-hint-experiment branch from e5f2f30 to bc40f0f Compare June 16, 2026 22:46
Base automatically changed from dev/adaley/recommended-plugin-hint-experiment to main June 16, 2026 23:04
adaley-openai added a commit that referenced this pull request Jun 16, 2026
Summary\n- Await endpoint recommendation selection while constructing
each authenticated turn, removing the first-turn cache race.\n- Snapshot
and filter endpoint candidates once per turn, then use that same set for
the bounded contextual user fragment, tool exposure, and exact install
validation.\n- Keep recommendation selection ephemeral: do not persist
recommendation state in or gate resumed threads on prior context.\n-
Hide the legacy list tool in endpoint mode and preserve legacy discovery
unchanged when the endpoint is disabled or unavailable.\n- Keep remote
plugin and connector app identities out of model-visible context and
attach them only to Codex-owned elicitation metadata.\n\nStack\n- 3/4,
based on #28400.\n- Endpoint client and cache: #28399.\n- Generalized
suggestion presentation: #28400.\n- Install-schema follow-up:
#28403.\n\nValidation\n- \n- \n- \n- \n- Full : 2,649 passed and 88
environment-dependent tests failed because this sandbox cannot write ,
nest Seatbelt, or locate auxiliary test binaries.
@adaley-openai
adaley-openai force-pushed the dev/adaley/simplify-recommended-plugin-install-schema branch from 1b361d1 to 8758a12 Compare June 16, 2026 23:21
@adaley-openai
adaley-openai enabled auto-merge (squash) June 16, 2026 23:27
@adaley-openai
adaley-openai merged commit a397b59 into main Jun 16, 2026
46 of 47 checks passed
@adaley-openai
adaley-openai deleted the dev/adaley/simplify-recommended-plugin-install-schema branch June 16, 2026 23:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants