[codex] expose Bedrock credential source in account/read#27751
Merged
Conversation
This was referenced Jun 12, 2026
celia-oai
force-pushed
the
dev/cc/managed-3
branch
from
June 12, 2026 03:56
764919e to
0164825
Compare
celia-oai
marked this pull request as ready for review
June 12, 2026 03:58
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 016482524f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
celia-oai
force-pushed
the
dev/cc/managed-3
branch
2 times, most recently
from
June 12, 2026 17:50
66e7199 to
1e6ae6d
Compare
pakrym-oai
approved these changes
Jun 15, 2026
celia-oai
force-pushed
the
dev/cc/managed-3
branch
from
June 16, 2026 04:54
1e6ae6d to
a025639
Compare
celia-oai
enabled auto-merge (squash)
June 16, 2026 04:54
This was referenced Jun 16, 2026
celia-oai
force-pushed
the
dev/cc/managed-3
branch
from
June 16, 2026 06:49
a025639 to
a028e42
Compare
celia-oai
force-pushed
the
dev/cc/managed-3
branch
from
June 16, 2026 07:09
a028e42 to
e0a2c1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
account/readcurrently reports onlytype: "amazonBedrock", so clients cannot distinguish a Codex-managed Bedrock API key from credentials supplied by AWS. The app UI needs that distinction to render the appropriate account state without duplicating provider-auth logic.Credential-source selection belongs to the Bedrock model provider because it already owns the precedence between managed Bedrock auth and the external AWS credential path. This builds on #27443 and #27689.
What changed
AmazonBedrockCredentialSourcewithcodexManagedandawsManagedvalues.ProviderAccount::AmazonBedrockand the app-serverAccountresponse.AmazonBedrockModelProvider::account_state()classify the source from its managed-auth state.codexManagedmeans the provider found a managed Bedrock API key.awsManagedidentifies the provider's external AWS credential path; it does not assert that the AWS credential chain has been validated.Testing
account/readresponses.just test -p codex-protocol -p codex-model-provider -p codex-app-server-protocol(497 tests passed).After rebasing onto #27711, the
codex-app-servertest target compiled past the image-generationPathUrimigration. Local linking was then interrupted by disk exhaustion (No space left on device).