exec-server: own portable sandbox permission wire types#28126
Closed
anp-oai wants to merge 1 commit into
Closed
Conversation
anp-oai
force-pushed
the
codex/exec-server-permission-path-uri-wire
branch
from
5c7995f to
1fe7001
Compare
anp-oai
changed the base branch from
main
to
codex/cross-platform-path-rendering
anp-oai
commented
Jun 13, 2026
| rejected as an invalid request. | ||
|
|
||
| Sandboxed operations run in a hidden helper process launched from the | ||
| top-level `codex` executable and prepared through the shared sandbox transform |
Collaborator
Author
There was a problem hiding this comment.
remove this second paragraph from this diff
| @@ -0,0 +1,168 @@ | |||
| use std::num::NonZeroUsize; | |||
Collaborator
Author
There was a problem hiding this comment.
what if we extracted the sandbox types to a protocol_shared crate and make the stack of types generic over the path representation? we could define a trait for a sandbox path if we need generic code to do things with the paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The exec-server filesystem API should carry paths portably and evolve independently from core sandbox permission types. Reusing the core types exposed host-native
AbsolutePathBufvalues and coupled the public JSON contract tocodex_protocol.Stacked on #27819, which provides the cross-platform path rendering used by this change.
What changed
PathUri.read/writeJSON compatibility while serializing canonical tagged profiles withfile:URIs.Validation
Added round-trip and JSON compatibility coverage for every permission variant, foreign URI rejection, and URI-bearing permission paths crossing the websocket RPC boundary.