path-uri: render native paths across platforms#27819
Merged
Merged
Conversation
anp-oai
force-pushed
the
codex/cross-platform-path-rendering
branch
from
187ee86 to
f773a8e
Compare
anp-oai
force-pushed
the
codex/cross-platform-path-rendering
branch
from
d92bef6 to
b31483c
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b31483c038
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
added a commit
that referenced
this pull request
Jun 13, 2026
anp-oai
commented
Jun 13, 2026
anp-oai
force-pushed
the
codex/cross-platform-path-rendering
branch
from
596e482 to
b31483c
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 13, 2026
anp-oai
commented
Jun 13, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 13, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 13, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 13, 2026
anp-oai
commented
Jun 13, 2026
anp-oai
commented
Jun 13, 2026
This was referenced Jun 13, 2026
anp-oai
commented
Jun 13, 2026
anp-oai
commented
Jun 13, 2026
anp-oai
commented
Jun 13, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 13, 2026
anp-oai
commented
Jun 13, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 13, 2026
This was referenced Jun 13, 2026
pakrym-oai
reviewed
Jun 14, 2026
pakrym-oai
reviewed
Jun 14, 2026
pakrym-oai
reviewed
Jun 14, 2026
pakrym-oai
approved these changes
Jun 14, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 14, 2026
anp-oai
force-pushed
the
codex/cross-platform-path-rendering
branch
from
3971173 to
b19077b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We're moving to
PathUriin more places to support cross-OS app-server/exec-server, but we don't want to expose the URI encoding to users of app-server's public APIs yet.We'll need to translate at the app-server API boundary between client-visible "regular" paths that are appropriate for the OS of the environment for which the paths make sense, which means using the environment's path personality to do the conversion.
PathUridoesn't yet attempt to encode environment ID, so for now we'll sniff the most likely path convention for a given path.What
PathConventionandNativePathStringwith host-independent POSIX, Windows drive, and UNC rendering.