app-server: preserve target-native environment cwd#28146
Merged
Conversation
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
2ea8378 to
0899d52
Compare
anp-oai
commented
Jun 14, 2026
| @@ -3844,27 +3852,6 @@ fn turn_start_params_treat_null_or_omitted_environments_as_default() { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
Collaborator
Author
There was a problem hiding this comment.
for human reviewers: this layer can't enforce that absolute paths are required anymore, this is moved to a thread start test
anp-oai
added a commit
that referenced
this pull request
Jun 14, 2026
anp-oai
commented
Jun 14, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 167b3b9a5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Jun 14, 2026
anp-oai
force-pushed
the
codex/cross-platform-path-rendering
branch
from
3971173 to
b19077b
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 14, 2026
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
2 times, most recently
from
5baa76a to
e22628c
Compare
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e22628cbbe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
added a commit
that referenced
this pull request
Jun 16, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 16, 2026
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
6144dc1 to
68d1d00
Compare
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
68d1d00 to
9f9f025
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 16, 2026
## Why In #28146 I missed the invariant that an absolute `exec_command` workdir must override the environment cwd. The existing integration test would have caught that regression, but it was ignored as flaky. ## What Re-enable `unified_exec_respects_workdir_override`. ## Validation `just test -p codex-core unified_exec_respects_workdir_override`
pakrym-oai
approved these changes
Jun 16, 2026
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
b6c0886 to
be6caaa
Compare
anp-oai
force-pushed
the
codex/app-server-remote-environment-cwd
branch
from
be6caaa to
fa970c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
app-server may run on a different OS from the selected exec-server environment. Parsing that environment’s cwd with the Codex host’s path rules prevents thread startup.
What
Carry environment cwd values as
LegacyAppPathStringat the app-server boundary andPathUriinternally. Existing tool-call schemas and relative-path behavior stay host-native; remaining local-only consumers convert explicitly and leave follow-up TODOs.The Wine integration test verifies app-server can start a thread and complete an ordinary turn with a Windows environment cwd from Linux.
Validation
bazel test //codex-rs/core/tests/remote_env_windows:smoke-test --test_output=errorscodex-coreandcodex-app-server-protocol