[codex] re-enable absolute workdir integration test#28581
Merged
Conversation
anp-oai
force-pushed
the
codex/restore-absolute-workdir-test
branch
from
3864447 to
3d95478
Compare
anp-oai
changed the title
sayan-oai
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In #28146 I missed the invariant that an absolute
exec_commandworkdir must override the environment cwd. The existing integration test would have caught that regression, but it was ignored as flaky.What
Re-enable
unified_exec_respects_workdir_override.Validation
just test -p codex-core unified_exec_respects_workdir_override