exec: preserve command cwd as PathUri#28563
Closed
anp-oai wants to merge 4 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands may execute in an environment whose path convention differs from the app-server host. Their cwd must remain environment-native through execution, approvals, and emitted command items.
This carries command cwd as
PathUrithrough core execution and approval events, renders it as an API path string at the app-server boundary, and limits host-native projection to code that actually parses commands on the host.Stacked on #28560.
Validation:
just test -p codex-app-server-protocolbazel test //codex-rs/core/tests/remote_env_windows:smoke-test --test_output=errorsjust fixfor the affected crates