unified-exec: preserve PathUri through exec-server#28681
Merged
Conversation
anp-oai
added a commit
that referenced
this pull request
Jun 17, 2026
anp-oai
marked this pull request as ready for review
June 17, 2026 08:22
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 086d92fa4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
force-pushed
the
codex/unified-exec-path-uri
branch
from
June 17, 2026 17:23
18f241d to
0a89eef
Compare
pakrym-oai
reviewed
Jun 17, 2026
pakrym-oai
reviewed
Jun 17, 2026
pakrym-oai
reviewed
Jun 17, 2026
pakrym-oai
reviewed
Jun 17, 2026
|
|
||
| loop { | ||
| if matches!( | ||
| wait_for_event(&test.codex, |_| true).await, |
Contributor
There was a problem hiding this comment.
uber nit: wait_for_event is already waiting internally
pakrym-oai
approved these changes
Jun 17, 2026
anp-oai
force-pushed
the
codex/unified-exec-path-uri
branch
from
June 17, 2026 18:16
e59c3f7 to
f41fce8
Compare
anp-oai
force-pushed
the
codex/unified-exec-path-uri
branch
from
June 17, 2026 19:17
f41fce8 to
198d4b3
Compare
anp-oai
enabled auto-merge (squash)
June 17, 2026 19:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
It should be possible for app-server to handle "foreign" OS paths in unified_exec working directories, allowing e.g. a Linux app-server to run processes on e.g. a Windows exec-server.
What
Convert the core unified_exec cwd values to use
PathUri.Adds fallible path conversion in several places to try to minimize the scope of this change. The only time this change suppresses errors from converting
PathUrito anAbsolutePathBufis when the turn is configured with no sandboxing at all to allow us to make progress testing without sandboxing.Future changes to apply_patch and sandboxing will clean up these error paths.
A tool's cwd is resolved from joining a model-provided workdir to the environment's cwd. When using
AbsolutePathBuf::join(), an absolute-path workdir would overwrite the environment's cwd and we would resolve permissions/sandboxing against the model-provided path. This change extendsPathUri::join()to also treat an absolute rhs as an override of the base/lhs.This also removes some coverage from the remove_env_windows tests until a follow-up converts foreign paths in command exec events correctly.
Breaking Changes
When using
AbsolutePathBuf::join()for workdir resolution, we ended up resolving tilde-prefixed paths against the app-server's$HOME, e.g.~/foo/barbecomes/home/anp/foo/bar. It's difficult to do this withPathUrijoining, so after offline discussion this PR no longer implements it.A quick check of some power users' rollouts suggests that models don't actually generate home-prefixed absolute working directories for their spawns, so this shouldn't have any real blast radius.