unified-exec: retain PathUri in command events#28780
Merged
Merged
Conversation
anp-oai
force-pushed
the
codex/unified-exec-path-uri-events
branch
from
88553e0 to
a9753c0
Compare
anp-oai
force-pushed
the
codex/unified-exec-path-uri-events
branch
4 times, most recently
from
e77b52c to
77b4c91
Compare
anp-oai
changed the title
anp-oai
force-pushed
the
codex/unified-exec-path-uri-events
branch
2 times, most recently
from
8f4f0d3 to
452ef2a
Compare
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 452ef2a696
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pakrym-oai
reviewed
Jun 18, 2026
pakrym-oai
reviewed
Jun 18, 2026
pakrym-oai
reviewed
Jun 18, 2026
pakrym-oai
reviewed
Jun 18, 2026
pakrym-oai
requested changes
Jun 18, 2026
pakrym-oai
left a comment
pakrym-oai
left a comment
Collaborator
There was a problem hiding this comment.
Should we make individual items slightly wrong instead of fully skipping them?
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
Collaborator
Author
Yeah very reasonable for these events that aren't involved in e.g. sandboxing decisions. Moved the PR to mostly failing open. |
pakrym-oai
approved these changes
Jun 18, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 18, 2026
anp-oai
force-pushed
the
codex/unified-exec-path-uri-events
branch
from
ba64b63 to
77e063d
Compare
anp-oai
force-pushed
the
codex/unified-exec-path-uri-events
branch
from
77e063d to
d8d296c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
App-server must report command events containing foreign-platform paths without changing existing client or rollout path-string formats.
What changed
PathUrithrough exec command begin/end eventsLegacyAppPathStringat the app-server compatibility boundary