Sanitize skill names in injection metrics - #34601
Merged
copyberry[bot] merged 1 commit intoJul 21, 2026
Merged
Conversation
## Why Skill names may contain characters that are not valid in metric tag values. ## What changed Pass skill names through `sanitize_metric_tag_value` before using them as the `skill` tag on `codex.skill.injected` counters for both explicit and implicit skill invocations. GitOrigin-RevId: 0ed633fbd468739acc30193b566d830e20bc7860
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/0ed633fbd468739acc30193b566d830e20bc7860
branch
from
July 21, 2026 19:26
5a7f49f to
6c00dc0
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/0ed633fbd468739acc30193b566d830e20bc7860
branch
July 21, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sanitize skill names in injection metrics
Why
Skill names may contain characters that are not valid in metric tag values.
What changed
Pass skill names through
sanitize_metric_tag_valuebefore using them as theskilltag oncodex.skill.injectedcounters for both explicit and implicitskill invocations.