Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion codex-rs/core-skills/src/injection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ use codex_analytics::SkillInvocation;
use codex_analytics::TrackEventsContext;
use codex_exec_server::LOCAL_FS;
use codex_otel::SessionTelemetry;
use codex_otel::sanitize_metric_tag_value;
use codex_protocol::user_input::UserInput;
use codex_utils_absolute_path::AbsolutePathBuf;
use codex_utils_path_uri::PathUri;
Expand Down Expand Up @@ -135,11 +136,12 @@ fn emit_skill_injected_metric(
let Some(otel) = otel else {
return;
};
let skill_name_tag = sanitize_metric_tag_value(skill.name.as_str());

otel.counter(
"codex.skill.injected",
/*inc*/ 1,
&[("status", status), ("skill", skill.name.as_str())],
&[("status", status), ("skill", skill_name_tag.as_str())],
);
}

Expand Down
4 changes: 3 additions & 1 deletion codex-rs/core/src/skills.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use codex_analytics::SkillInvocation;
use codex_analytics::build_track_events_context;
use codex_extension_api::SkillInvocationInput;
use codex_extension_api::SkillInvocationKind;
use codex_otel::sanitize_metric_tag_value;
use codex_protocol::protocol::SkillScope;
use codex_utils_absolute_path::AbsolutePathBuf;
use codex_utils_plugins::PluginSkillRoot;
Expand Down Expand Up @@ -87,6 +88,7 @@ pub(crate) async fn maybe_emit_implicit_skill_invocation(
if !inserted {
return;
}
let skill_name_tag = sanitize_metric_tag_value(skill_name.as_str());

for contributor in sess.services.extensions.skill_invocation_contributors() {
contributor
Expand All @@ -106,7 +108,7 @@ pub(crate) async fn maybe_emit_implicit_skill_invocation(
/*inc*/ 1,
&[
("status", "ok"),
("skill", skill_name.as_str()),
("skill", skill_name_tag.as_str()),
("invoke_type", "implicit"),
],
);
Expand Down
Loading