[Repo Assist] fix(security): remove residual ex.Message leak in canvas jsonlPath error path - #328
Merged
shanselman merged 4 commits intoMay 14, 2026
Conversation
PR #294 sanitised the main canvas command handlers (navigate, eval, snapshot, a2ui) but left one ex.Message leak at the jsonlPath read path: Error($"Failed to read jsonlPath: {ex.Message}"). The exception detail was already written to the local logger on the line above, so diagnostic fidelity is preserved; only the gateway-bound error string is stripped. Closes: the residual canvas capability gap identified post-#294. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assert sanitized jsonlPath error responses now that internal exception details stay local to logs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
shanselman
marked this pull request as ready for review
May 14, 2026 01:56
shanselman
deleted the
repo-assist/fix-canvas-jsonlpath-exmessage-leak-2026-05-13-78f4414fcfd54f2f
branch
May 14, 2026 02:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Repo Assist — automated AI assistant.
PR #294 sanitized the main canvas command handlers (
navigate,eval,snapshot,a2ui.dump,a2ui.caps) but oneex.Messageleak was left in thejsonlPathread path inHandleA2UIAsync:The exception is already written to the local logger on the line immediately above:
So diagnostic fidelity is fully preserved — only the gateway-bound error string is sanitized.
Relation to existing security work
NodeCapabilityerrorsCanvasCapability+BrowserProxyCapability(most handlers)WindowsNodeClient,DeviceCapability, approval servicesCanvasCapabilityjsonlPath handlerTest Status
dotnet test OpenClaw.Shared.Tests --no-restore— ✅ exit 0dotnet test OpenClaw.Tray.Tests --no-restore— ✅ exit 0build.ps1— requires Windows; infrastructure limitation on Linux runner