Skip to content

[Repo Assist] fix(security): remove residual ex.Message leak in canvas jsonlPath error path #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanselman merged 4 commits into from
May 14, 2026
Merged

[Repo Assist] fix(security): remove residual ex.Message leak in canvas jsonlPath error path #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
618fcf6
fix(security): remove ex.Message leak in canvas jsonlPath error response
github-actions[bot] May 13, 2026
a415994
Merge remote-tracking branch 'origin/master' into pr-328
shanselman May 14, 2026
ab75d44
Update canvas jsonlPath security tests
shanselman May 14, 2026
3894774
Merge remote-tracking branch 'origin/master' into pr-328
shanselman May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenClaw.Shared/Capabilities/CanvasCapability.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ private NodeInvokeResponse HandleA2UIPush(NodeInvokeRequest request)
catch (Exception ex)
{
Logger.Error($"{request.Command}: failed to read jsonlPath", ex);
return Error($"Failed to read jsonlPath: {ex.Message}");
return Error("Failed to read jsonlPath");
}
}

Expand Down
4 changes: 2 additions & 2 deletions tests/OpenClaw.Shared.Tests/A2UICapabilitySecurityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public async Task A2UIPush_FileJsonl_OverCap_ReturnsError()
};
var res = await cap.ExecuteAsync(req);
Assert.False(res.Ok);
Assert.Contains("maximum size", res.Error);
Assert.Equal("Failed to read jsonlPath", res.Error);
}
finally
{
Expand Down Expand Up @@ -125,7 +125,7 @@ public async Task A2UIPush_FileJsonl_SymlinkOutsideTemp_ReturnsError()
var res = await cap.ExecuteAsync(req);

Assert.False(res.Ok);
Assert.Contains("temp", res.Error, StringComparison.OrdinalIgnoreCase);
Assert.Equal("Failed to read jsonlPath", res.Error);
}
finally
{
Expand Down
4 changes: 2 additions & 2 deletions tests/OpenClaw.Shared.Tests/CapabilityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,7 @@ public async Task A2UIPush_WithJsonlPathOutsideTempDir_ReturnsError()
};
var res = await cap.ExecuteAsync(req);
Assert.False(res.Ok);
Assert.Contains("temp directory", res.Error);
Assert.Equal("Failed to read jsonlPath", res.Error);
}

[Fact]
Expand All @@ -1506,7 +1506,7 @@ public async Task A2UIPush_WithJsonlPathTraversal_ReturnsError()
};
var res = await cap.ExecuteAsync(req);
Assert.False(res.Ok);
Assert.Contains("temp directory", res.Error);
Assert.Equal("Failed to read jsonlPath", res.Error);
}

[Fact]
Expand Down
Loading