Adding plugin code from edx-platform - #48
Conversation
There was a problem hiding this comment.
Thanks @jinder1s.
- I didn't really look at code, because I presume you didn't touch it. Let me know if you made changes and what I should look for.
I don't have any background on "Plugin Contexts" and how baked it is, and whether it should be marked Accepted in the ADR and should be moved along with everything else. :)
UPDATE: Looks like "Plugin Contexts" are marked as Adopt, so we should be all set in moving it as well. See https://github.com/edx/edx-platform/pull/24057/files#r465341119
previous location in edx-platform: https://github.com/edx/edx-platform/tree/master/openedx/core/djangoapps/plugins
Adding more code
0f8c137 to
a498191
Compare
robrap
left a comment
There was a problem hiding this comment.
Some final details before approval:
- See comment
- Temporarily omit files from codecov with TODO comment pointing to ticket that will add coverage.
- Codecov has been having issues on this repo. Is that a global issue, or does config for this repo need to be reviewed, or do we need to open a ticket with them?
- Please add PR comment when you have successful sandbox using plugin.
Can you elaborate more on what you mean by "add coverage"? @robrap |
|
@jinder1s: I mean adding tests. |
|
You could add the pragma for no cover (search for ‘pragma’) to the if statement below to bump up coverage for the project. 38 | 4 | declared_middleware = getattr(settings, 'MIDDLEWARE', None) |
robrap
left a comment
There was a problem hiding this comment.
Once you get codecov to green and have tested in LMS.
PR in edx-platform that tests this move: https://github.com/edx/edx-platform/pull/24678
previous location in edx-platform: https://github.com/edx/edx-platform/tree/master/openedx/core/djangoapps/plugins
This is mostly a drop in replacement, though with some link changes and I ran black on plugin directory.
Link to working sandbox: https://plugless.sandbox.edx.org/
Description:
Describe in a couple of sentence what this PR adds
JIRA:
XXX-XXXX
Dependencies:
List dependencies on other outstanding PRs, issues, etc.
Merge deadline:
List merge deadline (if any)
Installation instructions:
List any non-trivial installation
instructions.
Testing instructions:
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns:
List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.