Extracting plugin app from edx-platform - #24678
Conversation
|
jenkins run python |
| edx-django-sites-extensions | ||
| edx-django-utils | ||
| # TODO(jinder): uncomment below after plugin code has been moved | ||
| # edx-django-utils |
There was a problem hiding this comment.
@ reviewer: I plan on uncommenting this once this has merged: openedx/edx-django-utils#48
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Thanks.
- A lot of files were deleted, but I didn’t see references change. Are those all used local to plugins only?
- Do we want a short decision doc that points to the other one regarding moving plugins?
I've caught all the references to deleted files that I could find and as far as I can tell, the only file not referenced in edx_platform is .../plugins/utils.py, which is used internally by other deleted files.
This is a good idea. Will create one. |
|
We need a task for someone to do a local search through all repos for the following, to ensure we won't break anything: |
* Moving code * changing imports to point to edx-django-utils * make upgrade * Adding documentation
8cf41fa to
9ec4753
Compare
The now point to open api in edx_django_utils.plugins instead of edx_django_utils.plugins.{module_name}
| edx-django-release-util==0.4.4 # via -r requirements/edx/base.in | ||
| edx-django-sites-extensions==2.5.1 # via -r requirements/edx/base.in | ||
| edx-django-utils==3.6.0 # via -r requirements/edx/base.in, django-config-models, edx-drf-extensions, edx-enterprise, edx-rest-api-client, edx-when | ||
| -e git+https://github.com/edx/edx-django-utils.git@msingh/add/fix#egg=edx-django-utils # via -r requirements/edx/base.in, django-config-models, edx-drf-extensions, edx-enterprise, edx-rest-api-client, edx-when |
There was a problem hiding this comment.
@ reviewer I will remove this link once both this PR and edx-django-utils PR is ready to be merged. I'm leaving it so that any change made based on reviewer comments can be tested easily.
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Thanks. I tried to add "Nit" to those comments you can ignore, and not to those I'd like to see. I'll leave it up to you if you want to fix the Nits.
robrap
left a comment
robrap
left a comment
There was a problem hiding this comment.
Minor fixes and then all set, once requirements are updated.
|
jenkins run all |
1 similar comment
|
jenkins run all |
|
Your PR has finished running tests. There were no failures. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been rolled back from the production environment. |
This reverts commit c76ed6a. This broke Pathways in LabXChange.
|
EdX Release Notice: This PR has been deployed to the production environment. |
4 participants
ARCHBOM-1402
This PR extracts the code that enables plugins in edx-platform and puts it in edx-django-utils. This is done to allow other IDAS to add plugin functionality.
As of right now: this has been tested in sandbox and devstack. Things seem to be working.