fix: Update the API path and fix saving settings [BD-38] [TNL-8621] [BB-4854] - #197
Merged
Merged
Conversation
openedx-webhooks
added
core committer
open-source-contribution
|
Thanks for the pull request, @xitij2000! I've created BLENDED-975 to keep track of it in Jira. More details are on the BD-38 project page. When this pull request is ready, tag your edX technical lead. |
xitij2000
changed the title
openedx-webhooks
added
blended
mehaknasir
approved these changes
Oct 6, 2021
xitij2000
changed the title
awaisdar001
approved these changes
Oct 15, 2021
Contributor
|
@xitij2000 this needs a rebase and then it can be merged. |
Contributor
|
@xitij2000 can you link the dependent platform PR for this? |
Contributor
Author
I've updated the description to include these details. |
Contributor
|
@xitij2000 Please rebase. |
Contributor
Author
@awaisdar001 This PR depends on https://github.com/edx/edx-platform/pull/28749 |
Contributor
|
@xitij2000 The dependant PR has merged. Can you please rebase and make this one ready to merge? |
The discussions configuration API is now exposed via studio to allow saving course settings to the modulestore. The anonymous posts settings were also set up in a way that meant they were only saved if true, that is now fixed.
xitij2000
force-pushed
the
kshitij/tnl-8621/change-api-path
branch
from
October 27, 2021 11:28
eff72e1 to
11c2036
Compare
Contributor
Author
|
@asadazam93 Done. |
awais-ansari
approved these changes
Oct 28, 2021
|
@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
cgaber2045
pushed a commit
to cgaber2045/frontend-app-course-authoring
that referenced
this pull request
Jan 14, 2022
The discussions configuration API is now exposed via studio to allow saving course settings to the modulestore. The anonymous posts settings were also set up in a way that meant they were only saved if true, that is now fixed.
rpenido
pushed a commit
to open-craft/frontend-app-authoring
that referenced
this pull request
Jan 2, 2024
This PR upgrades React Router from v5 to v6. It is not a simple version bump. React Router v6 is a breaking change that includes many major changes to the router functionality.
bradenmacdonald
pushed a commit
to open-craft/frontend-app-authoring
that referenced
this pull request
Aug 9, 2024
* fix: use feedback icon with correct hover color * fix: problem answer layout squishes delete button background * fix: remove borders from textarea * fix: textarea resize * refactor: remove renderThing-antipattern in answer option * fix: answer option feedback color * fix: add second feedback box to all problem types * refactor: move extra components out of answer option file * fix: icon disappearing on hover when active * fix: update snapshot * fix: lint * fix: add tests * fix: add tests * fix: snapshots * Update src/editors/containers/ProblemEditor/components/EditProblemView/AnswerWidget/AnswerOption.jsx Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com> * fix: resolve discussions from PR Co-authored-by: Kristin Aoki <42981026+KristinAoki@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The discussions configuration API is now exposed via studio to allow saving course settings to the modulestore.
The anonymous posts settings were also set up in a way that meant they were only saved if true, that is now fixed.
JIRA tickets:
Dependencies: https://github.com/edx/edx-platform/pull/28749
Merge deadline: "None"
Testing instructions: