feat: Adds discussions settings for new discusions experience [BD-38] [TNL-8621] [BB-4854] - #29131
Conversation
This commit adds new discussions settings for the new discussions experience. These are stored in the course so they can be a part of course import/export flow. These are also added to the discussions configuraiton API to allow MFEs to update the settings. The discussions API is currently available via LMS, however that means it cannot save changes to the modulestore. This also adds the API to the studio config so it can now also be accessed from studio and be used to save course settings.
openedx-webhooks
added
blended
|
Thanks for the pull request, @xitij2000! I've created BLENDED-998 to keep track of it in Jira. More details are on the BD-38 project page. When this pull request is ready, tag your edX technical lead. |
| self.discussion_config = DiscussionsConfiguration.objects.create( | ||
| context_key=self.course.id, | ||
| enabled=False, | ||
| provider_type="lti_provider", | ||
| ) |
There was a problem hiding this comment.
The logic for deciding when the LTI tab is enabled was changed in this PR: https://github.com/edx/edx-platform/pull/29110
This PR updates the default provider type such that LTI support is disabled by default, and as such the test failes since it didn't take this condition into account.
|
Your PR has finished running tests. There were no failures. |
|
@xitij2000 Is this ready to be merged? |
If the only reason it was reverted was the failing test, then yes. |
|
@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
6 participants
Description
This commit adds new discussions settings for the new discussions experience. These are stored in the course so they can be a part of course import/export flow.
These are also added to the discussions configuration API to allow MFEs to update the settings.
Previously reverted due to a test failure.
Supporting information
Testing instructions
Deadline
"None"
Related PR: https://github.com/edx/edx-platform/pull/28749