[FC-0049] feat: Other Tags section added on tags drawer

[ChrisChV]

Description

This adds the new "Other tags" Section to tags drawer that contains the taxonomies/tags that the user doesn't have permission to see/edit. It allow to delete that tags.

Supporting information

• Github issue: [Tagging] Handle import course when the current user does not have permission modular-learning#204
• Internal ticket: FAL-3720
• Depends on:
  • [FC-0049] feat: Update remove object-tag permission openedx-platform#34728
  • [FC-0049] feat: Update permissions to remove object tags openedx-core#188

Testing instructions

• Use this branch of edx-platform: [FC-0049] feat: Update remove object-tag permission openedx-platform#34728
• Run make requirements on cms-shell.
• Run the script on https://github.com/open-craft/taxonomy-sample-data
• Go to taxonomy list page and import an small taxonomy: example: template (3).csv
• Ensure that the new taxonomy doesn't have associated organizations
• Go to Studio and create a new course usign SampleTaxonomyOrg1 as organization
• Import a course with taxonomies using the new taxonomy. You can use this example, but yu need to update the export_id of the new taxonomy: course.phoprzm8.tar.gz
• Open the manage tags of the course or any Unit
• Check the Other tags section
• Click on Edit mode
• Verify that you can't add more tags in Other tags section.
• Delete some tags and save. Verify that the tags and count are updated.
• Delete all Other tags and Save. Verify that the Other tags section is gone.

Other Information

TODO: It's missing to add examples to test this on https://github.com/open-craft/taxonomy-sample-data

[openedx-webhooks]

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.28%. Comparing base (55adcfe) to head (5d3e23c).

Files	Patch %	Lines
...rc/content-tags-drawer/ContentTagsDrawerHelper.jsx	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
- Coverage   92.28%   92.28%   -0.01%     
==========================================
  Files         707      707              
  Lines       12469    12493      +24     
  Branches     2671     2679       +8     
==========================================
+ Hits        11507    11529      +22     
- Misses        925      927       +2     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yusuf-musleh]

@ChrisChV I wasn't able to test this. Whenever I try to import a taxonomy, the /import endpoint hangs indefinitely. I made sure I checked the correct branches in all the repos (including openedx-learning). I even rebuilt everything from scratch (using tutor dev launch -I) to make sure it's not some weird state my env is in, but it leads to the same thing.

I also tried importing different kinds of taxonomies.

I'm not sure what the issue is, could you confirm that it is working correctly on your end?

Edit: Found these in the logs when I restarted the server:

Traceback (most recent call last):
  File "/openedx/venv/lib/python3.8/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/openedx/venv/lib/python3.8/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/opt/pyenv/versions/3.8.18/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/openedx/venv/lib/python3.8/site-packages/django/views/decorators/csrf.py", line 56, in wrapper_view
    return view_func(*args, **kwargs)
  File "/openedx/venv/lib/python3.8/site-packages/rest_framework/viewsets.py", line 125, in view
    return self.dispatch(request, *args, **kwargs)
  File "/openedx/venv/lib/python3.8/site-packages/rest_framework/views.py", line 509, in dispatch
    response = self.handle_exception(exc)
  File "/openedx/venv/lib/python3.8/site-packages/rest_framework/views.py", line 469, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/openedx/venv/lib/python3.8/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
    raise exc
  File "/openedx/venv/lib/python3.8/site-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
  File "/openedx/edx-platform/openedx/core/djangoapps/content_tagging/rest_api/v1/views.py", line 98, in create_import
    response = super().create_import(request=request, **kwargs)  # type: ignore
  File "/mnt/openedx-learning/openedx_tagging/core/tagging/rest_api/v1/views.py", line 325, in create_import
    resync_object_tags()
  File "/mnt/openedx-learning/openedx_tagging/core/tagging/api.py", line 169, in resync_object_tags
    object_tag.save()
  File "/openedx/venv/lib/python3.8/site-packages/django/db/models/base.py", line 814, in save
    self.save_base(
  File "/openedx/venv/lib/python3.8/site-packages/django/db/models/base.py", line 877, in save_base
    updated = self._save_table(
  File "/openedx/venv/lib/python3.8/site-packages/django/db/models/base.py", line 990, in _save_table
    updated = self._do_update(
  File "/openedx/venv/lib/python3.8/site-packages/django/db/models/base.py", line 1054, in _do_update
    return filtered._update(values) > 0
  File "/openedx/venv/lib/python3.8/site-packages/django/db/models/query.py", line 1231, in _update
    return query.get_compiler(self.db).execute_sql(CURSOR)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/models/sql/compiler.py", line 1984, in execute_sql
    cursor = super().execute_sql(result_type)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/models/sql/compiler.py", line 1562, in execute_sql
    cursor.execute(sql, params)
  File "/openedx/venv/lib/python3.8/site-packages/debug_toolbar/panels/sql/tracking.py", line 235, in execute
    return self._record(super().execute, sql, params)
  File "/openedx/venv/lib/python3.8/site-packages/debug_toolbar/panels/sql/tracking.py", line 160, in _record
    return method(sql, params)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/backends/utils.py", line 102, in execute
    return super().execute(sql, params)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/backends/utils.py", line 67, in execute
    return self._execute_with_wrappers(
  File "/openedx/venv/lib/python3.8/site-packages/django/db/backends/utils.py", line 80, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/utils.py", line 91, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/openedx/venv/lib/python3.8/site-packages/django/db/backends/utils.py", line 89, in _execute
    return self.cursor.execute(sql, params)
  File "/openedx/venv/lib/python3.8/site-packages/django/db/backends/mysql/base.py", line 75, in execute
    return self.cursor.execute(query, args)
  File "/openedx/venv/lib/python3.8/site-packages/MySQLdb/cursors.py", line 179, in execute
    res = self._query(mogrified_query)
  File "/openedx/venv/lib/python3.8/site-packages/MySQLdb/cursors.py", line 330, in _query
    db.query(q)
  File "/openedx/venv/lib/python3.8/site-packages/MySQLdb/connections.py", line 261, in query
    _mysql.connection.query(self, query)
django.db.utils.OperationalError: (1205, 'Lock wait timeout exceeded; try restarting transaction')
Internal Server Error: /api/content_tagging/v1/taxonomies/import/

It seems to also be happening when I tried it on master/main for all repos, so it's probably not related to the changes in these PRs?

[ChrisChV]

@yusuf-musleh It's working using devstack, but I will test this using tutor

[ChrisChV]

@yusuf-musleh I have tried it and it has worked for me. It takes a little longer due to indexing in meilisearch. Maybe it's a configuration in meilisearch that's missing from your locale?

[bradenmacdonald]

@yusuf-musleh That sounds like it could be related to openedx/modular-learning#213 . I also couldn't reproduce it though (using tutor). Let's consider it part of that issue ^ and unrelated to this PR, if you're seeing on master too.

[ChrisChV]

I wasn't able to test this. Whenever I try to import a taxonomy, the /import endpoint hangs indefinitely. I made sure I checked the correct branches in all the repos (including openedx-learning). I even rebuilt everything from scratch (using tutor dev launch -I) to make sure it's not some weird state my env is in, but it leads to the same thing.

@yusuf-musleh If you are blocked for the import of the taxonomy, you can test this without import a taxonomy. You can use an already created taxonomy and delete any associated organization.

[bradenmacdonald]

Works well. Just one minor thing.

[bradenmacdonald]

Nit: This shouldn't be h6 because that's making the text bold. The text should not be bold.

vs.

[ChrisChV]

Updated here: 5a45416

[bradenmacdonald]

Thanks!

[bradenmacdonald]

@ChrisChV Could you please rebase this or resolve the conflicts?

[yusuf-musleh]

@ChrisChV @bradenmacdonald I tried it again today and it worked, not sure what changed, but its definitely not related to the changes here as you mentioned. It's working well!

👍

• I tested this: I followed the testing instructions in the PR
• I read through the code
• I checked for accessibility issues
• Includes documentation

[ChrisChV]

@bradenmacdonald Done!

@brian-smith-tcril @arbrandes @viktorrusakov @xitij2000 Does anyone have time to approve and merge this before Redwood gets cut? Thank you 🙂

[openedx-webhooks]

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.