Skip to content

[FC-0049] feat: Update remove object-tag permission - #34728

Merged
farhaanbukhsh merged 2 commits into
openedx:masterfrom
open-craft:chris/FAL-3720-update-remove-object-tag-permission
May 9, 2024
Merged

[FC-0049] feat: Update remove object-tag permission#34728
farhaanbukhsh merged 2 commits into
openedx:masterfrom
open-craft:chris/FAL-3720-update-remove-object-tag-permission

Conversation

@ChrisChV

@ChrisChV ChrisChV commented May 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Overrides can_remove_object_tag_objectid rule
  • Bump openedx-learning version

Supporting information

Testing instructions

Other information

  • Bump openedx-learning version

@openedx-webhooks

openedx-webhooks commented May 7, 2024 •
edited
Loading

Copy link
Copy Markdown

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 7, 2024
@ChrisChV
ChrisChV marked this pull request as draft May 7, 2024 21:00
@ChrisChV ChrisChV changed the title feat: Update remove object-tag permission [FC-0049] feat: Update remove object-tag permission May 7, 2024
@ChrisChV
ChrisChV force-pushed the chris/FAL-3720-update-remove-object-tag-permission branch from a0cb8b6 to 358f6fe Compare May 7, 2024 21:45
ChrisChV
ChrisChV commented May 7, 2024
View reviewed changes
Comment thread requirements/edx/kernel.in Outdated
@ChrisChV
ChrisChV marked this pull request as ready for review May 7, 2024 21:46
@ChrisChV ChrisChV mentioned this pull request May 7, 2024
Merged
@bradenmacdonald

bradenmacdonald commented May 8, 2024

Copy link
Copy Markdown
Contributor

Looks good. I tested it. Will approve once we've done the version bump of openedx-learning.

@bradenmacdonald
bradenmacdonald force-pushed the chris/FAL-3720-update-remove-object-tag-permission branch from 95bb9c6 to ad38401 Compare May 8, 2024 21:20
@bradenmacdonald

bradenmacdonald commented May 8, 2024

Copy link
Copy Markdown
Contributor

(just rebased this since the tests weren't green due to some GitHub CI bug)

bradenmacdonald added a commit to open-craft/openedx-platform that referenced this pull request May 8, 2024
@bradenmacdonald
Merge PR openedx#34728 'chris/FAL-3720-update-remove-object-tag-permi…
6ed84d8 
…ssion' into taxonomy-sandbox-20240508
yusuf-musleh
yusuf-musleh approved these changes May 9, 2024
View reviewed changes

@yusuf-musleh yusuf-musleh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @ChrisChV Its working well.

@farhaanbukhsh
farhaanbukhsh merged commit 7f6133c into openedx:master May 9, 2024
@farhaanbukhsh
farhaanbukhsh deleted the chris/FAL-3720-update-remove-object-tag-permission branch May 9, 2024 12:08
@openedx-webhooks

openedx-webhooks commented May 9, 2024

Copy link
Copy Markdown

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

edx-pipeline-bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

edx-pipeline-bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot

edx-pipeline-bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

edx-pipeline-bot commented May 9, 2024

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

rayzhou-bit pushed a commit that referenced this pull request May 9, 2024
@ChrisChV @rayzhou-bit
[FC-0049] feat: Update remove object-tag permission (#34728)
463169b 
* feat: Update remove object-tag permission

* chore: Bump openedx-learning version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes
+1 more reviewer
@yusuf-musleh yusuf-musleh yusuf-musleh approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ChrisChV @openedx-webhooks @bradenmacdonald @edx-pipeline-bot @yusuf-musleh @farhaanbukhsh