Fix linter warnings. - #43
Merged
Merged
Conversation
Fixed Swiftlint 0.51 warning about superfluous disable.
IvanStepanok
approved these changes
Jun 30, 2023
shafqat-muneer
pushed a commit
to shafqat-muneer/openedx-app-ios
that referenced
this pull request
Jul 30, 2024
* fix: batch updates * chore: fix ui update from background * fix: changed download queue * chore: a little refactor * fix: play pause - issue * fix: subtitles view for big videos * fix: download after internet off * chore: revert back config file * chore: fixed tests * chore: review changes * chore: changed analytic events
volodymyr-chekyrta
pushed a commit
that referenced
this pull request
Jan 29, 2025
* refactor: migrate project to swift 6 * fix: remove task in do after * fix: address feedback * fix: address feedback * fix: update pods * fix: update task priority * fix: download issues (#43) * fix: batch updates * chore: fix ui update from background * fix: changed download queue * chore: a little refactor * fix: play pause - issue * fix: subtitles view for big videos * fix: download after internet off * chore: revert back config file * chore: fixed tests * chore: review changes * chore: changed analytic events * fix: download of html * chore: fixed tryDownloadAgain * chore: merge issues * chore: regenerate mocks * chore: fix bug with downloading * fix: download issue * fix: download issue * fix: swift 6 bug with evaluate java script method * chore: merge swift6 branch * chore: disable file length * chore: fix tests * chore: removed useless code * chore: fix freezes during download * fix: download states * chore: fixed tests * chore: merge conflicts * chore: merge issues * fix: some download bugs * fix: for condition race * fix: size in DownloadActionView * chore: remove extra line * chore: fix crash * chore: tests fix * chore: added tests for CourseDownloadHelperTests * chore: added more tests * chore: fix test * chore: fix test * chore: commit to re-run jobs * chore: increased waiting time for test * chore: test fix * chore: trying to fix unit tests * chore: removed multiple publisher tests --------- Co-authored-by: IvanStepanok <ivan.stepanok@raccoongang.com>
IvanStepanok
pushed a commit
to raccoongang/openedx-app-ios
that referenced
this pull request
Sep 1, 2025
Beautified some code to align with the code style. Fixed Swiftlint 0.51 warning about superfluous disable.
IvanStepanok
added a commit
to raccoongang/openedx-app-ios
that referenced
this pull request
Sep 1, 2025
* refactor: migrate project to swift 6 * fix: remove task in do after * fix: address feedback * fix: address feedback * fix: update pods * fix: update task priority * fix: download issues (openedx#43) * fix: batch updates * chore: fix ui update from background * fix: changed download queue * chore: a little refactor * fix: play pause - issue * fix: subtitles view for big videos * fix: download after internet off * chore: revert back config file * chore: fixed tests * chore: review changes * chore: changed analytic events * fix: download of html * chore: fixed tryDownloadAgain * chore: merge issues * chore: regenerate mocks * chore: fix bug with downloading * fix: download issue * fix: download issue * fix: swift 6 bug with evaluate java script method * chore: merge swift6 branch * chore: disable file length * chore: fix tests * chore: removed useless code * chore: fix freezes during download * fix: download states * chore: fixed tests * chore: merge conflicts * chore: merge issues * fix: some download bugs * fix: for condition race * fix: size in DownloadActionView * chore: remove extra line * chore: fix crash * chore: tests fix * chore: added tests for CourseDownloadHelperTests * chore: added more tests * chore: fix test * chore: fix test * chore: commit to re-run jobs * chore: increased waiting time for test * chore: test fix * chore: trying to fix unit tests * chore: removed multiple publisher tests --------- Co-authored-by: IvanStepanok <ivan.stepanok@raccoongang.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beautified some code to align with the code style.
Fixed Swiftlint 0.51 warning about superfluous disable.