Merge of DownloadManager with upstream/develop - #562
Merged
Conversation
* fix: batch updates * chore: fix ui update from background * fix: changed download queue * chore: a little refactor * fix: play pause - issue * fix: subtitles view for big videos * fix: download after internet off * chore: revert back config file * chore: fixed tests * chore: review changes * chore: changed analytic events
volodymyr-chekyrta
previously approved these changes
Jan 28, 2025
Contributor
|
Need to figure out the CLA issue before merge |
Contributor
Created request for this openedx/axim-engineering#1368 |
forgotvas
dismissed stale reviews from volodymyr-chekyrta and rnr
via
January 29, 2025 11:31
1df7322
|
I'm going to try closing and re-opening this to see if the CLA check updates |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #562 +/- ##
========================================
Coverage ? 0
========================================
Files ? 0
Lines ? 0
Branches ? 0
========================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
brian-smith-tcril
changed the title
brian-smith-tcril
changed the title
volodymyr-chekyrta
approved these changes
Jan 29, 2025
IvanStepanok
added a commit
to raccoongang/openedx-app-ios
that referenced
this pull request
Sep 1, 2025
* refactor: migrate project to swift 6 * fix: remove task in do after * fix: address feedback * fix: address feedback * fix: update pods * fix: update task priority * fix: download issues (openedx#43) * fix: batch updates * chore: fix ui update from background * fix: changed download queue * chore: a little refactor * fix: play pause - issue * fix: subtitles view for big videos * fix: download after internet off * chore: revert back config file * chore: fixed tests * chore: review changes * chore: changed analytic events * fix: download of html * chore: fixed tryDownloadAgain * chore: merge issues * chore: regenerate mocks * chore: fix bug with downloading * fix: download issue * fix: download issue * fix: swift 6 bug with evaluate java script method * chore: merge swift6 branch * chore: disable file length * chore: fix tests * chore: removed useless code * chore: fix freezes during download * fix: download states * chore: fixed tests * chore: merge conflicts * chore: merge issues * fix: some download bugs * fix: for condition race * fix: size in DownloadActionView * chore: remove extra line * chore: fix crash * chore: tests fix * chore: added tests for CourseDownloadHelperTests * chore: added more tests * chore: fix test * chore: fix test * chore: commit to re-run jobs * chore: increased waiting time for test * chore: test fix * chore: trying to fix unit tests * chore: removed multiple publisher tests --------- Co-authored-by: IvanStepanok <ivan.stepanok@raccoongang.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contain
1.mov
_after.mov