Skip to content

Update problem-builder to version 2.0.3 - #11818

Merged
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:omar/problem-builder
Mar 17, 2016
Merged

Update problem-builder to version 2.0.3#11818
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:omar/problem-builder

Conversation

@omarkhan

Copy link
Copy Markdown
Contributor

Bug

The 'Download report' link on the problem builder dashboard is currently broken. Images are not always displayed, for 2 reasons:

  • If the image is from a different domain and it has been cached by the browser, it is not converted into a data URL due to cross-domain security issues. A javascript SecurityError is thrown, and nothing happens.
  • If the image url starts with // (no explicit protocol) or the url is relative (e.g. /static/...), and it has not yet been cached by the browser, it will fail to show up in the downloaded report.

Fix

These issues have been fixed in version 2.0.3 of problem builder (see open-craft/problem-builder#106). This pull request updates edx-platform to use the new version.

Testing

  1. Go to the sandbox at http://pr11818.sandbox.opencraft.com/
  2. Register for the demo course
  3. Navigate to Introduction → Test Questions
  4. Answer the questions. 1 is correct, 2 is incorrect
  5. Go to the Test Dashboard subsection. You should see something like this:
    screen shot 2016-03-17 at 13 11 51
  6. Click 'Download report'. The image should display correctly in the downloaded report.

Partner information

Harvard GSE course hosted on edx.org (Data Wise)

Settings

edx_ansible_source_repo: 'https://github.com/open-craft/configuration.git'
configuration_version: 'omar/revert-dogwood-merge'

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @omarkhan! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?repo=edx%2Fedx-platform&number=11818

@Kelketek

Copy link
Copy Markdown
Contributor

👍 Don't forget to have a sandbox prepared for upstream.

@omarkhan

Copy link
Copy Markdown
Contributor Author

Sandbox is up and running: http://pr11818.sandbox.opencraft.com/

@bradenmacdonald

Copy link
Copy Markdown
Contributor

@tobz Can you please review this hash update PR related to the Problem Builder PR you recently reviewed? We'd like to ensure this fix is in this week's release cut.

@tobz

tobz commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

LGTM. 👍

@bradenmacdonald

Copy link
Copy Markdown
Contributor

Thanks @tobz !

bradenmacdonald added a commit that referenced this pull request Mar 17, 2016
Update problem-builder to version 2.0.3
@bradenmacdonald
bradenmacdonald merged commit 8aff51b into openedx:master Mar 17, 2016
@bradenmacdonald
bradenmacdonald deleted the omar/problem-builder branch March 17, 2016 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants