Update tabs.py - #1234
Conversation
fixes tab buttons of student's dahsboard for i18n
|
Gah, I'm sorry we left this pull request untouched for so long. :( In order to merge it, we'll need to you sign an individual contributor agreement, as documented in the CONTRIBUTING file in the repository. |
|
sent. such a pity that the term AGPL is not mentioned in any way on this 2013/10/17 David Baumgold notifications@github.com
|
|
Contributor agreement received. |
There was a problem hiding this comment.
You have an extra comma in this line that is causing a SyntaxError in the unit tests.
|
Once we get the tests passing (remove the extra comma), this is ready to merge. It would be nice if you could also add yourself to the |
|
Hi @oliviermarquez - could you please rebase your branch on master? Your branch has some conflicts that need to be resolved, as well as a failing test that is not due to your code changes. |
There was a problem hiding this comment.
Conventionally, we like the final closing brace to appear at the same indentation level as the first line (so at the same indentation level of course.tabs - an indent of only 4, not 8, spaces in this case).
|
Done in pr #1489 |
fixes tab buttons of student's dahsboard for i18n - replace pr #757