Skip to content

Update tabs.py #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oliviermarquez wants to merge 3 commits into from
Closed

Update tabs.py #1234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49d1337
Update tabs.py
oliviermarquez Oct 7, 2013
164282d
Update tabs.py
oliviermarquez Oct 18, 2013
26fdeee
Update AUTHORS
oliviermarquez Oct 18, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,4 @@ Akshay Jagadeesh <akjags@gmail.com>
Nick Parlante <nick.parlante@cs.stanford.edu>
Marko Seric <marko.seric@math.uzh.ch>
Felipe Montoya <felipe.montoya@edunext.co>
Olivier Marquez <oliviermarquez@gmail.com>
13 changes: 8 additions & 5 deletions cms/djangoapps/contentstore/views/tabs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from ..utils import get_course_for_item, get_modulestore
from .access import get_location_and_verify_access

from django.utils.translation import ugettext as _

__all__ = ['edit_tabs', 'reorder_static_tabs', 'static_pages']

Expand All @@ -31,11 +32,13 @@ def initialize_course_tabs(course):

# This logic is repeated in xmodule/modulestore/tests/factories.py
# so if you change anything here, you need to also change it there.
course.tabs = [{"type": "courseware"},
{"type": "course_info", "name": "Course Info"},
{"type": "discussion", "name": "Discussion"},
{"type": "wiki", "name": "Wiki"},
{"type": "progress", "name": "Progress"}]
course.tabs = [
{"type": "courseware", "name": _("Courseware")},
{"type": "course_info", "name": _("Course Info")},
{"type": "discussion", "name": _("Discussion")},
{"type": "wiki", "name": _("Wiki")},
{"type": "progress", "name": _("Progress")},
]

@sarina sarina Oct 24, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conventionally, we like the final closing brace to appear at the same indentation level as the first line (so at the same indentation level of course.tabs - an indent of only 4, not 8, spaces in this case).


modulestore('direct').update_metadata(course.location.url(), own_metadata(course))

Expand Down