Remove "show_closed_captions" in cookie - #13798
Conversation
|
Thanks for the pull request, @myleshk! I've created OSPR-1519 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. If you like, you can add yourself to the AUTHORS file for this repo, though that isn't required. Please see the CONTRIBUTING file for more information. |
|
jenkins run all |
|
Just made some new changes that should fix relevant test failures. Not sure for other test failures about "problems" as I just changed one JavaScript file of video player. Please run tests again, thank you. |
|
jenkins run all |
|
I'm closing this because the major problem this PR tries to solve is cause by my ignorance of edX MDC. However, for Problem 2 I still think it is bothering ordinary users with occasional needs to use captions, e.g. due to noisy environment, unfamiliar terms in one video. |
Storing caption status in global cookie is wired. Below are my reasons:
Please check this problem. Thx.