Fix js that prevented single step OE problems (ie only self assessment) ... - #2
Merged
Merged
Conversation
Contributor
Author
|
@brianhw Would you mind reviewing this? |
Contributor
|
It works! (Thanks for helping me to run this.) |
VikParuchuri
added a commit
that referenced
this pull request
May 31, 2013
Fix js that prevented single step OE problems (ie only self assessment) ...
valera-rozuvan
pushed a commit
that referenced
this pull request
Jun 19, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jun 21, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jun 26, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jun 28, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 1, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 3, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 4, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 9, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 10, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 11, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 12, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 16, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 18, 2013
Added missing file.~ Undid a mistake. Copied Python tests from video_alpha1. moves TestLogic to __init__.py reorginizes xmodule logic tests adds docstrings for poll tests adds docstring for word cloud and conditional tests adds docstrings for video alpha tests adds videoalphafactory for tests, not finished adds imports Bug fixing. fix video/videoalpha tests Updated lettuce test. Now it is aware of the fact that Video and Video Alpha players have different base CSS classes. Removed REFACTOR comments. Turn off autoplay for Video Alpha in Studio. Carry over fix for bug where in Firefox changing to speed 1.0 has no effect. Carry over JavaScript Jasmine tests from jmclaus/videoalpha2_js branch. Exporting state object from main function of Video Alpha. More stuff from jmclaus/videoalpha2_js branch. Specs in html5_video.js all pass except ten of them. Cleaned code a bit and moved it out of display_spec.js One more spec passes Fixed remaning tests in spec/../html5_video.js test suite. Removed test video files. Added JavaScript Jasmine tests for main of Video Alpha 2. adds test for volume control and updates helper file for videoalpha
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 22, 2013
Added missing file.~ Undid a mistake. Copied Python tests from video_alpha1. moves TestLogic to __init__.py reorginizes xmodule logic tests adds docstrings for poll tests adds docstring for word cloud and conditional tests adds docstrings for video alpha tests adds videoalphafactory for tests, not finished adds imports Bug fixing. fix video/videoalpha tests Updated lettuce test. Now it is aware of the fact that Video and Video Alpha players have different base CSS classes. Removed REFACTOR comments. Turn off autoplay for Video Alpha in Studio. Carry over fix for bug where in Firefox changing to speed 1.0 has no effect. Carry over JavaScript Jasmine tests from jmclaus/videoalpha2_js branch. Exporting state object from main function of Video Alpha. More stuff from jmclaus/videoalpha2_js branch. Specs in html5_video.js all pass except ten of them. Cleaned code a bit and moved it out of display_spec.js One more spec passes Fixed remaning tests in spec/../html5_video.js test suite. Removed test video files. Added JavaScript Jasmine tests for main of Video Alpha 2. adds test for volume control and updates helper file for videoalpha
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 22, 2013
Added missing file.~ Undid a mistake. Copied Python tests from video_alpha1. moves TestLogic to __init__.py reorginizes xmodule logic tests adds docstrings for poll tests adds docstring for word cloud and conditional tests adds docstrings for video alpha tests adds videoalphafactory for tests, not finished adds imports Bug fixing. fix video/videoalpha tests Updated lettuce test. Now it is aware of the fact that Video and Video Alpha players have different base CSS classes. Removed REFACTOR comments. Turn off autoplay for Video Alpha in Studio. Carry over fix for bug where in Firefox changing to speed 1.0 has no effect. Carry over JavaScript Jasmine tests from jmclaus/videoalpha2_js branch. Exporting state object from main function of Video Alpha. More stuff from jmclaus/videoalpha2_js branch. Specs in html5_video.js all pass except ten of them. Cleaned code a bit and moved it out of display_spec.js One more spec passes Fixed remaning tests in spec/../html5_video.js test suite. Removed test video files. Added JavaScript Jasmine tests for main of Video Alpha 2. adds test for volume control and updates helper file for videoalpha
vetrolamu
referenced
this pull request
in pelikanchik/edx-platform
Jul 30, 2013
valera-rozuvan
pushed a commit
that referenced
this pull request
Jul 31, 2013
Added missing file.~ Undid a mistake. Copied Python tests from video_alpha1. moves TestLogic to __init__.py reorginizes xmodule logic tests adds docstrings for poll tests adds docstring for word cloud and conditional tests adds docstrings for video alpha tests adds videoalphafactory for tests, not finished adds imports Bug fixing. fix video/videoalpha tests Updated lettuce test. Now it is aware of the fact that Video and Video Alpha players have different base CSS classes. Removed REFACTOR comments. Turn off autoplay for Video Alpha in Studio. Carry over fix for bug where in Firefox changing to speed 1.0 has no effect. Carry over JavaScript Jasmine tests from jmclaus/videoalpha2_js branch. Exporting state object from main function of Video Alpha. More stuff from jmclaus/videoalpha2_js branch. Specs in html5_video.js all pass except ten of them. Cleaned code a bit and moved it out of display_spec.js One more spec passes Fixed remaning tests in spec/../html5_video.js test suite. Removed test video files. Added JavaScript Jasmine tests for main of Video Alpha 2. adds test for volume control and updates helper file for videoalpha
This was referenced Oct 14, 2016
3 tasks
7 tasks
2 tasks
3 tasks
2 tasks
2 tasks
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...from working
Prior to this, open response assessment problems with only a single "step" would not render the rubric properly or display a submission confirmation message. This fixes those issues.
Required ASAP for PH278, which wants to use an open response question with a single step.