Move a component - #14315
Merged
Merged
Conversation
mushtaqak
force-pushed
the
mushtaq/move-component
branch
from
January 26, 2017 12:00
11f86e8 to
e1d0af3
Compare
|
jenkins run lettuce |
mushtaqak
force-pushed
the
mushtaq/move-component
branch
2 times, most recently
from
February 8, 2017 14:23
347ba8f to
bcda015
Compare
mushtaqak
force-pushed
the
mushtaq/move-component
branch
from
February 15, 2017 08:19
7a2fed7 to
a12ee2d
Compare
Get ancestor info for the given xblock - TNL-6061
TNL-6047
- TNL-6062 - TNL-6229
mushtaqak
force-pushed
the
mushtaq/move-component
branch
from
March 1, 2017 14:28
a12ee2d to
e9b8e17
Compare
bokchoy tests for move xblocks
Allow move for content experiment
|
@mushtaqak Can we add description to this PR and add links of all the sub-PRs that we've created for this feature with 1 liner to see what they have. |
Contributor
|
@muzaffaryousaf Yes, doc is ready to merge too. |
…omponent will now be the sibling of groups) Fixed Move button is disabled when moving components inside conditional module Fixed When navigating upward/backward, target parent is not set correct, resulting source to be moved in the previously selected parent
Move Bug fixes
Add i18n to backend error messages in case they appear to end user Remove success banner when trying to publish or discard changes on container page
Remove success banner on container state change
|
jenkins run lettuce |
7 tasks
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to move a component to another location in the course.
This adds a move icon to a component. When move icon is clicked, the concise course outline is fetched and rendered via a modal dialog, which has the ability to navigate the course tree. The modal dialog describes which component is moved and tracks the current location (item ancestors). It only enables move button when a valid move operation can be made, otherwise it disabled.
When a component is moved, A mini notification is shown, reflecting the move operation is in progress, once operation is complete, successful confirmation message is shown to notify that the move operation is done. It also adds a link to the location component is moved. Furthermore, we also have the ability to undo the move operation which would put back the component to it original location.
The moved component is placed at the last index inside the new location.
TNL-5943
Sub PRs
#14204 : This PR adds the backend view to return tree for course outline and any given block
#14227 : This PR adds the backend view to move a component
#14254 : This PR adds move modal dialog
#14362 : This PR renders course outline and breadcrumbs on move modal
#14352 : This PR handles move and undo move front-end work
#14352 : This PR enables/ disables move button
#14457 : This PR restricts move operation for some cases and adds content experiments
#14364 : Test fixes
#14465 : This PR adds bokchoy tests
#14625 : This PR fixes some bugs introduced.
#14659 : This PR remove success banner on discard changes and adds logging and i18n support