Move Bug fixes - #14625
Merged
Merged
Conversation
Contributor
Author
|
jenkins run bokchoy |
Contributor
Author
|
jenkins run lettuce |
mushtaqak
force-pushed
the
mushtaq/bug-bash-fixes
branch
from
March 8, 2017 07:33
03c9480 to
bc43ad7
Compare
Contributor
There was a problem hiding this comment.
@mushtaqak typo : sourcepParentHasChildren -> sourceParentHasChildren
Contributor
Author
There was a problem hiding this comment.
After move, move dialog need to be closed. We were previously doing this too.
There was a problem hiding this comment.
Little comment would be helpful to understand underlying purpose.
There was a problem hiding this comment.
Let's not use single line doc strings..
|
@mushtaqak This looks good now 👍 |
muhammad-ammar
approved these changes
Mar 8, 2017
muhammad-ammar
left a comment
muhammad-ammar
left a comment
Contributor
There was a problem hiding this comment.
This looks great 👍
…omponent will now be the sibling of groups) Fixed Move button is disabled when moving components inside conditional module Fixed When navigating upward/backward, target parent is not set correct, resulting source to be moved in the previously selected parent
mushtaqak
force-pushed
the
mushtaq/bug-bash-fixes
branch
from
March 8, 2017 11:50
bc43ad7 to
e83bee6
Compare
Contributor
Author
|
jenkins run lettuce |
|
@mushtaqak Let's merge this as it. |
Contributor
Author
|
@muzaffaryousaf So we are merging this ? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bugs found in Move feature bug bash. Following are the bugs that are fixed :
Backend: Move component directly to content experiment level (component will now be the sibling of groups)
Fixed Move button is disabled when moving components inside conditional module
Fixed When navigating upward/backward, target parent is not set correct, resulting source to be moved in the previously selected parent
After a component is moved, Published version is not changed to Draft version unless user manually refreshes the page.
Sandbox