Skip to content

fix a few xss errors - #16726

Merged
efischer19 merged 1 commit into
masterfrom
efischer/xss_followup
Dec 4, 2017
Merged

fix a few xss errors#16726
efischer19 merged 1 commit into
masterfrom
efischer/xss_followup

Conversation

@efischer19

@efischer19 efischer19 commented Nov 30, 2017

Copy link
Copy Markdown
Contributor

Followup to https://github.com/edx/edx-platform/pull/16723, since I wanted to get that merged ASAP

@UmanShahzad @robrap

Note that this PR is currently pointed at my branch, not master.

@robrap
robrap self-requested a review November 30, 2017 16:37
robrap
robrap requested changes Nov 30, 2017
View reviewed changes

@robrap robrap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop the Total threshold by 3 as well and this is ready to go. Thanks.

@efischer19
efischer19 force-pushed the efischer/xss_followup branch from 38cdc6a to b05b685 Compare November 30, 2017 16:43
@efischer19

efischer19 commented Nov 30, 2017

Copy link
Copy Markdown
Contributor Author

I've updated the commit. Oddly, I'm getting 30 more failures when I run paver run_xsslint locally. I'm curious to see if jenkins matches, since paver run_xsscommitlint reports no new issues.

@efischer19
efischer19 force-pushed the efischer/xss_followup branch from b05b685 to 079c158 Compare November 30, 2017 17:00
@efischer19
efischer19 changed the base branch from efischer/xss_limit to master November 30, 2017 17:02
@efischer19

efischer19 commented Nov 30, 2017

Copy link
Copy Markdown
Contributor Author

jenkins run lettuce

@efischer19

efischer19 commented Nov 30, 2017

Copy link
Copy Markdown
Contributor Author

jenkins run bokchoy

@robrap

robrap commented Nov 30, 2017 via email

Copy link
Copy Markdown
Contributor

@efischer19
efischer19 force-pushed the efischer/xss_followup branch from 079c158 to 3687d6a Compare December 4, 2017 16:56
@efischer19

efischer19 commented Dec 4, 2017

Copy link
Copy Markdown
Contributor Author

@robrap could you re-review this PR when you get a minute?

robrap
robrap approved these changes Dec 4, 2017
View reviewed changes

@robrap robrap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I thought I was done with this. I know should have marked as provisionally Approved once you updated the total. :)

@efischer19
efischer19 merged commit d0250ba into master Dec 4, 2017
@efischer19
efischer19 deleted the efischer/xss_followup branch December 4, 2017 19:16
@efischer19

efischer19 commented Dec 4, 2017

Copy link
Copy Markdown
Contributor Author

No worries, thanks for the help here!

@edx-pipeline-bot

edx-pipeline-bot commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, December 05, 2017.

@edx-pipeline-bot

edx-pipeline-bot commented Dec 5, 2017

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robrap robrap robrap approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efischer19 @robrap @edx-pipeline-bot