Skip to content

fix a few xss errors #16726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efischer19 merged 1 commit into from
Dec 4, 2017
Merged

fix a few xss errors #16726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/test/test_sites/test_site/templates/courseware/tabs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
tab_class = url_class(tab_is_active)
%>
<li>
<a href="${tab.link_func(course, reverse) | h}" class="${tab_class}">
Test Site Tab: ${_(tab.name) | h}
<a href="${tab.link_func(course, reverse)}" class="${tab_class}">
Test Site Tab: ${_(tab.name)}
% if tab_is_active:
<span class="sr">, current location</span>
%endif
Expand Down
2 changes: 1 addition & 1 deletion common/test/test_sites/test_site/templates/static_templates/contact.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</div>
<div class="contacts">
<h2>${_("Class Feedback")}</h2>
<p>${_("We are always seeking feedback to improve our courses. If you are an enrolled student and have any questions, feedback, suggestions, or any other issues specific to a particular class, please post on the discussion forums of that&nbsp;class.")}</p>
<p>${_("We are always seeking feedback to improve our courses. If you are an enrolled student and have any questions, feedback, suggestions, or any other issues specific to a particular class, please post on the discussion forums of that class.")}</p>

<h2>${_("General Inquiries and Feedback")}</h2>
<p>${_('If you have a general question about {platform_name} please email {email}. To see if your question has already been answered, visit our {faq_link_start}FAQ page{faq_link_end}. You can also join the discussion on our {fb_link_start}facebook page{fb_link_end}. Though we may not have a chance to respond to every email, we take all feedback into consideration.').format(
Expand Down
6 changes: 3 additions & 3 deletions scripts/xsslint_thresholds.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"javascript-jquery-insert-into-target": 23,
"javascript-jquery-insertion": 19,
"javascript-jquery-prepend": 7,
"mako-html-entities": 1,
"mako-html-entities": 0,
"mako-invalid-html-filter": 11,
"mako-invalid-js-filter": 192,
"mako-js-html-string": 0,
Expand All @@ -17,7 +17,7 @@
"mako-multiple-page-tags": 0,
"mako-unknown-context": 0,
"mako-unparseable-expression": 0,
"mako-unwanted-html-filter": 2,
"mako-unwanted-html-filter": 0,
"python-close-before-format": 0,
"python-concat-html": 24,
"python-custom-escape": 13,
Expand All @@ -28,5 +28,5 @@
"python-wrap-html": 226,
"underscore-not-escaped": 507
},
"total": 1754
"total": 1751
}