Add some blocks to course_about.html - #17091
Conversation
|
👍
|
|
Thanks for the pull request, @clemente! I've created OSPR-2056 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. If you like, you can add yourself to the AUTHORS file for this repo, though that isn't required. Please see the CONTRIBUTING file for more information. |
|
@tuchfarber Can you take this one also? |
|
@clemente 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Monday, January 15, 2018. |
Now that https://github.com/edx/edx-platform/pull/16856/ was merged, themes can implement particular blocks in templates, without having to redefine the whole
.htmlFor this we need the definition of the blocks to be redefined. This PR adds block names to some sections of
course_about.htmlthat we needed to rewrite.JIRA tickets: None
Discussions: None
Dependencies: None
Screenshots: None
Sandbox URL: https://pr17091.sandbox.opencraft.hosting/ , https://studio-pr17091.sandbox.opencraft.hosting/
Merge deadline: None
Testing instructions:
Adding blocks should be harmless. But if you want to test it in practice and check the new block override system, these are the full testing instructions:
lms/templates/course_about.htmlwhich redefines one of the blocks, e.g.<%block name="course_about_header">Reviewers
Author concerns: None
Settings: None