Change video transcripts to use locators instead of locations. - #1790
Merged
Conversation
Author
There was a problem hiding this comment.
This was missing a var declaration.
Part of STUD-870
Contributor
|
Looks good for me 👍 |
Contributor
|
👍 |
Contributor
|
Another issue that this PR fixes: BLD-554. |
cahrens
pushed a commit
that referenced
this pull request
Dec 4, 2013
Change video transcripts to use locators instead of locations.
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 24, 2017
* Add font-style normal. openedx#1790 * Mod error message when disable to register student-self with input status. openedx#1787 * Mod biz-menu style height to min-height. openedx#1793 * Fix review(TYPO).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STUD-870
@auraz and @polesye Please review this PR (including checking it out and testing the video transcript workflow manually). All tests are passing, but I don't know how these functions work well enough to manually test myself.
I did consider leaving some of the variable names as "component_id" instead of changing to "component_locator" (to reduce the number of changes in the PR). However, that was causing me confusion when trying to understand if I changed everything that I needed to.
I have not done anything to the form of the URLs. Since changing video transcript URLs to be RESTful is not necessary for unblocking the database re-architecture epic, we have decided to postpone that work.