i18n (forums) - #1793
Closed
singingwolfboy wants to merge 1 commit into
Closed
Conversation
Closed
There was a problem hiding this comment.
This needs to be refactored so the placeholder for the number of votes is included in the translation string
|
How can we be sure that the gettext function is available for the .coffee files? Also, there are a bunch of places where role names are output that need to have translation applied. |
Contributor
Author
|
@gwprice The best way to ensure that the |
ghost
assigned
|
Forums team will be picking up this work soon, but I'm going to close this PR in the meantime. |
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 24, 2017
* Add font-style normal. openedx#1790 * Mod error message when disable to register student-self with input status. openedx#1787 * Mod biz-menu style height to min-height. openedx#1793 * Fix review(TYPO).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1785 with only forums changes
@gwprice