settings.MITX_FEATURES => settings.FEATURES - #1827
Merged
Merged
Conversation
Contributor
|
This should also include a change log entry as it will affect anyone running an instance of the platform that is overriding the features dict. |
Contributor
Author
|
It would actually be nice to provide a transition period for the environment variable by doing |
For a smoother transition to the new world
Contributor
Author
|
@gwprice Done. |
|
👍 |
feanil
referenced
this pull request
in openedx-unsupported/configuration
Dec 3, 2013
This is to correspond to the same fix in the edx platform. https://github.com/edx/edx-platform/pull/1827
Contributor
|
@gwprice good idea, opened https://github.com/edx/configuration/pull/518 to match the new configuration to this since the sandboxes use that along with master, gonna wait to update our currently running configurations until after this is released, which seems like it will not be for a week and a half. changes look good. |
singingwolfboy
added a commit
that referenced
this pull request
Dec 4, 2013
settings.MITX_FEATURES => settings.FEATURES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of #1815
@gwprice @feanil