Waheed/ora72 consistent rubric scores 2

[waheedahmed]

No description provided.

[adampalay]

@waheedahmed , can you explain why this PR is able to provide a normalized score on the fly without writing it to the db?

[adampalay]

@dianakhuang , can you take a look?

[waheedahmed]

@adampalay @dianakhuang In this PR we are overwriting latest_score and all_score in OpenEndedModule, where we are returning sum of rubric scores for ML grading otherwise returning attempt["score"] without modifying data in DB. For this purpose we wrote function score_for_attempt and if we want to update scores in DB then we can use normalize_scores which is currently not using in this PR.

[symbolist]

OpenEndedModule is a child class of OpenEndedChild. The method get_score of CombinedOpenEndedV1Module uses all_scores of OpenEndedChild to retrieve scores of all attempts of all task_states.

This all_scores() method in OpenEndedModule instead of simply picking the value from the attempt dictionary as is done in OpenEndedChild uses self.score_for_attempt()

[dianakhuang]

I think this looks good.

[dianakhuang]

I think you might need to rebase off master as well because you have a few extraneous commits.

[adampalay]

@waheedahmed , be sure to touch base with @wedaly about testing before merging

[wedaly]

The unit tests look reasonable. As we discussed, this definitely needs end-to-end testing. I'd expect you to verify:

1. That student progress pages continue to display correctly for ORA problems:

• Both with existing and new submissions
• For all assessment types (self, AI, peer, and combined)

2. That grade export in the instructor dash completes without errors (check the error log).

You can do this testing either in Vagrant fullstack or in a sandbox. I'd recommend testing the demo course, which contains all the ORA problem types. Please document the testing that you've completed in a wiki page.

I'd also like @ormsbee to look this over for potential grading impact that we might have missed.

[waheedahmed]

@wedaly here the details of the testing we did: https://edx-wiki.atlassian.net/wiki/display/ORA/ORA-72+Testing

[wedaly]

Looks good to me, thanks for documenting the testing.
I'm seeing a flakey JavaScript test that we disabled on Friday causing tests to fail. Please rebase so the tests rerun.

👍 Once the tests pass

[adampalay]

@waheedahmed , while you're rebasing, can you make this pull request against the current release branch? We're going to try to hotfix this in ASAP

[waheedahmed]

Rebased against release.

https://github.com/edx/edx-platform/pull/1905