Adding settings and requirements for dogslow. - #1918
Closed
e0d wants to merge 1 commit into
Closed
Conversation
Contributor
|
I'd rather have dogslow being an option in aws.py, rather than being a separate environment file. The proliferation of environment files is unfortunate, in my mind. |
Contributor
Author
|
Seems reasonable, but what scheme do we use for optionally including it? Environment variable? |
Contributor
|
It's aws.py, so read it out of env.json. Have a single variable that controls whether it's on or off, and then more variables for the more specific configuration as needed. |
Contributor
|
LGPL is fine. |
Contributor
Author
|
@cpennington I'm going to close this for now. I don't think more JSON config is the way to go, but take your point about the proliferation of settings files. |
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cpennington @jarv @feanil
@jtauber for the new requirement
The creates a new environment that inherits everything from aws.py and does the following
This PR does not integrate dogslow directly into aws.py as I'd like to run in selectively for a while before blessing it.
We should also change the logging directory, but that will require an additional PR against the config repo to create a sensible directory and/or integrate dogslow with rsyslog.