Fix image mapping in IE

[polesye]

BLD-413

In the IE pos_x and pos_y are floats, but should be integers. Float numbers are not supported by regExp.
Additional rounding is added.

@valera-rozuvan , @auraz please review.

[auraz]

👍

[auraz]

please add comment why we use round

[valera-rozuvan]

In this file the variables iidiv, pos_x, pos_y, result, cx, and cy are leaked into the global namespace. Make sure that they are declared locally.

[valera-rozuvan]

In line 1

window.image_input_click = function(id,event){

please include spaces after function, and after ',', and before '{'.

[valera-rozuvan]

By the way, I think there are a lot of spaces messing = ) Before and after '+'. Before and after ':'. Before and after '?'. Before and after '-'.

= )

[valera-rozuvan]

In comment

// click on image, return coordinates

there is a misleading statement that the function returns coordinates. Either update the comment, or return coordinates.

[polesye]

@valera-rozuvan and @auraz All comments are addressed. Please check.

[valera-rozuvan]

Why not

cross = $("#cross_" + id);

and then

cross.css({'left': cx, 'top': cy});

?

[valera-rozuvan]

@polesye I think you should rewrite this file using jQuery. Follow the rule: "always check back in code in better state than you checked it out".

[auraz]

@valera-rozuvan next time maybe

[valera-rozuvan]

👍 Good to merge. My last 2 comments are just little wishes. If you want to make me happy - you can fix them. = )

[polesye]

@valera-rozuvan I do not want to add additional dependency here.

[valera-rozuvan]

@polesye In IE9 I get a very strange error - please see this screenshot. Do you think it is the browser responsible for it? Or is this behavior hard-coded into edx-platform JavaScript code base?

This happens when I click the Check button.

[valera-rozuvan]

@polesye I have also checked Google Chrome on the same platform and with the same local edx-platform CMS setup. I am able to Check the answer, and it correctly identifies right and wrong placement of the green dot.

[polesye]

@valera-rozuvan Error in IE9 is not related to current PR.

[valera-rozuvan]

@polesye I can no longer reproduce the bug when I click the Check button. I tried from fresh setup locally in VirtualBox, and also on SauceLabs. The green dot is behaves as expected, Check button also reveals correct and incorrect as expected.

👍 Good to merge.