Skip to content

BB-573 Restore code needed to set custom icon - #19496

Closed
malinoff wants to merge 1 commit into
openedx:open-release/hawthorn.masterfrom
open-craft:dmitry/BB-573
Closed

BB-573 Restore code needed to set custom icon#19496
malinoff wants to merge 1 commit into
openedx:open-release/hawthorn.masterfrom
open-craft:dmitry/BB-573

Conversation

@malinoff

@malinoff malinoff commented Dec 21, 2018

Copy link
Copy Markdown

This is the upstream PR for changes made in a local repository.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @malinoff! I've created OSPR-2921 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Dec 21, 2018
@malinoff
malinoff changed the base branch from open-release/hawthorn.master to master December 21, 2018 11:17
@malinoff
malinoff changed the base branch from master to open-release/hawthorn.master December 21, 2018 11:17
@malinoff

Copy link
Copy Markdown
Author

Closing this PR as per @xitij2000 comment - will open a new one against master branch.

@malinoff malinoff closed this Dec 21, 2018
@openedx-webhooks

Copy link
Copy Markdown

@malinoff Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants