Skip to content

BB-573 Restore code needed to set custom icon - #19498

Closed
malinoff wants to merge 1 commit into
openedx:masterfrom
open-craft:dmitry/BB-573
Closed

BB-573 Restore code needed to set custom icon#19498
malinoff wants to merge 1 commit into
openedx:masterfrom
open-craft:dmitry/BB-573

Conversation

@malinoff

@malinoff malinoff commented Dec 21, 2018

Copy link
Copy Markdown

Same as #19496, but made against master branch.

@openedx-webhooks

openedx-webhooks commented Dec 21, 2018

Copy link
Copy Markdown

Thanks for the pull request, @malinoff! I've created OSPR-2923 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Dec 21, 2018
@natabene

Copy link
Copy Markdown
Contributor

@malinoff Thank you for your contribution. Could you provide a more detailed description to help us understand the purpose of this?

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Dec 21, 2018
@malinoff

malinoff commented Dec 21, 2018

Copy link
Copy Markdown
Author

@natabene of course! The original request from our client is below:

The custom-set unit icons that we use to indicate video units (since Wistia video embeds are not detected) and downloads are missing from the LMS. It is no longer possible to set these in Studio either - that setting has been removed from the unit settings.

In other words, there was the setting in Ginko, but it is no more in Hawthorn.
I made a PR against the downstream edx repository and @xitij2000 asked me to create a PR for the upstream.

@openedx-webhooks openedx-webhooks added product review PR requires product review before merging and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Dec 21, 2018
@natabene

Copy link
Copy Markdown
Contributor

@malinoff Thank you for providing details. @marcotuts Can you have a look at this or do you want to send it to engineering review?

@xitij2000

Copy link
Copy Markdown
Contributor

@natabene This is very much a WIP currently. Will ping when it is ready for review.

@natabene

Copy link
Copy Markdown
Contributor

@xitij2000 Got it, thanks for the update.

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed product review PR requires product review before merging labels Dec 21, 2018
@Agrendalath

Copy link
Copy Markdown
Member

@natabene, could you please close this PR? This is not a desirable solution, as described in #19772.

@natabene

natabene commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

@Agrendalath Sure, will do.

@natabene natabene closed this Feb 8, 2019
@openedx-webhooks

Copy link
Copy Markdown

@malinoff Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@Agrendalath

Copy link
Copy Markdown
Member

@natabene, thank you!

@Agrendalath
Agrendalath deleted the dmitry/BB-573 branch February 8, 2019 17:11
@openedx-webhooks openedx-webhooks added rejected and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants