Studio: Updating Google Font Syntax - #1956
Merged
Merged
Conversation
Contributor
Author
|
@singingwolfboy and @frrrances, mind taking a look at this quick optimization PR? I want to make sure the calls are going through and that the Open Sans font-face is rendering in stack when viewing pages (both were just fine for me with a cache-cleared local env). |
ghost
assigned
Contributor
|
This pull request depends on #1961, or in some way allowing us to specify protocol-relative URLs in CSS files without Django-Pipeline falling over. |
* since Sass can now process @import rules * to simplify the number of external calls * maintains the http/https agnostic work * removes unused Bree Serif font face
Contributor
|
Looks good to me! 👍 |
Contributor
|
Looks good! 👍 |
talbs
added a commit
that referenced
this pull request
Dec 20, 2013
Studio: Updating Google Font Syntax
Contributor
Author
|
Thanks! Brought to "Mergetown". |
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jun 23, 2017
…-message-search-course Mod message for search-course. openedx#1927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With our upgrade to Sass a bit ago, we can now use plain CSS imports (Google's preferred syntax for embedding their web fonts) This work updates our _fonts.scss font file import syntax: