Studio HTTPS Fonts (re-enable) - #1975
Conversation
|
I think that #1956 is a better way to fix this issue since this version of saas supports CSS imports. |
|
@tusbar should I remove the changes to |
|
Now that #1956 has been merged, I rebased this PR and dropped the changes to |
|
@tusbar, thanks so much for your help in cleaning up our web font references. I agree that the syntax used in #1956 is what we want to apply to common/static/css/tiny-mce.css as well. I've talked to @singingwolfboy, and we settled on me testing out that syntax in a new PR (which I'll reference here). We'll then rebase this PR onto master/that work to make sure you're added to our contributors list officially (to acknowledge all of the help you've provided). I'll be in touch shortly with a new PR reference. Feel free to review that work as well. Thanks again! |
|
Hi, all. I've merged in #2019. @singingwolfboy, mind rebasing and removing common/static/css/tiny-mce.css from changed files in this PR as we talked about? This PR will essentially be then getting @tusbar the proper recognition he deserves for helping make these bits better. Thanks again, @tusbar! |
To acknowledge his help with refactoring URLs in our CSS to be protocol-relative
Studio HTTPS Fonts (re-enable)
Now that #1966 is merged, the tests should pass.
Reviewers: @marcotuts @talbs